unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Cochran <robert+Emacs@cochranmail.com>
To: npostavs@users.sourceforge.net
Cc: 27122@debbugs.gnu.org, Vasilij Schneidermann <v.schneidermann@gmail.com>
Subject: bug#27122: 26.0.50; [PATCH] Add customizable to display unprintables as hex
Date: Mon, 29 May 2017 17:47:49 -0700	[thread overview]
Message-ID: <87y3tftbka.fsf@SoraLaptop> (raw)
In-Reply-To: <87fufn430m.fsf@users.sourceforge.net> (npostavs's message of "Mon, 29 May 2017 20:11:37 -0400")

npostavs@users.sourceforge.net writes:

> While I'm also okay with changing this to hex display without an option,
> I don't think that commit introduced the octal behaviour, it just
> changed the implementation.  I think these these removed lines used to
> do it:
>
> -		    /* Insert three more glyphs into IT->ctl_chars for
> -		       the octal display of the character.  */
> -		    g = ((str[i] >> 6) & 7) + '0';
> -		    XSETINT (it->ctl_chars[i * 4 + 1], g);
> -		    g = ((str[i] >> 3) & 7) + '0';
> -		    XSETINT (it->ctl_chars[i * 4 + 2], g);
> -		    g = (str[i] & 7) + '0';
> -		    XSETINT (it->ctl_chars[i * 4 + 3], g);

Indeed. I wasn't looking closely enough. I mentally skipped over that
part because it was below the new sprintf. My bad, thanks for catching
that.

-- 
~Robert Cochran

GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26  AD2D E5C3 EB36 4886 8871





  reply	other threads:[~2017-05-30  0:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28 20:42 bug#27122: 26.0.50; [PATCH] Add customizable to display unprintables as hex Vasilij Schneidermann
2017-05-29  2:33 ` Eli Zaretskii
2017-05-29  6:28   ` Vasilij Schneidermann
2017-05-29 18:46     ` Robert Cochran
2017-05-29 19:52       ` Eli Zaretskii
2017-05-29 20:20         ` Vasilij Schneidermann
2017-05-29 23:55           ` Robert Cochran
2017-05-30  0:11             ` npostavs
2017-05-30  0:47               ` Robert Cochran [this message]
2017-05-29 19:39     ` Eli Zaretskii
2017-05-29 20:15       ` Vasilij Schneidermann
2017-05-30  6:24         ` Eli Zaretskii
2017-05-30  8:16           ` Vasilij Schneidermann
2017-05-30  8:38             ` Eli Zaretskii
2017-06-01 17:05               ` Vasilij Schneidermann
2017-06-01 18:19                 ` Eli Zaretskii
2017-05-30 12:06           ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3tftbka.fsf@SoraLaptop \
    --to=robert+emacs@cochranmail.com \
    --cc=27122@debbugs.gnu.org \
    --cc=npostavs@users.sourceforge.net \
    --cc=v.schneidermann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).