unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: David Engster <deng@randomsample.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Jerry Asher <jerry.asher@gmail.com>, 10478@debbugs.gnu.org
Subject: bug#10478: 24.0.50; url-http-parse-headers can silently drop the response when handling BASIC AUTHENTICATION
Date: Sat, 03 Jun 2017 12:41:47 +0200	[thread overview]
Message-ID: <87y3t9xsic.fsf@engster.org> (raw)
In-Reply-To: <8737uqyzam.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 25 Dec 2015 22:49:05 +0100")

Lars Ingebrigtsen writes:
> Jerry Asher <jerry.asher@gmail.com> writes:
>
>> When making a GET request again their simplest api, users/me that
>> returns information about the logged in user, url-retrieve-synchronously
>> will return the wrong buffer.
>>
>> This seems to be traceable to url-http-parse-headers handling the "401
>> Basic: Access denied message by" calling url-http-handle-authentication
>> which prompts the user for a name and password and calls
>> url-retrieve-internal to retry the request.
>
> I can confirm that this bug is still present in Emacs 25.  It returns
> the buffer with the 401 message, not the buffer with the response...

I just stumpled upon this. Oh my, this stuff is straight from callback
hell. Lars, how's your 'url' rewrite going...?

I stared at this for hours, but was unable to come up with anything
better than what Jerry has suggested. So if nobody objects, I'd like to
commit this.

Jerry, do you have papers with the FSF signed? I'm not sure if the
resulting patch will fit in the 'trivial patch' category.

-David





  reply	other threads:[~2017-06-03 10:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11  7:03 bug#10478: 24.0.50; url-http-parse-headers can silently drop the response when handling BASIC AUTHENTICATION Jerry Asher
2012-01-11  7:54 ` bug#10478: Possible fix?? Jerry Asher
2012-01-11  9:42   ` Michael Albinus
2015-12-25 21:49 ` bug#10478: 24.0.50; url-http-parse-headers can silently drop the response when handling BASIC AUTHENTICATION Lars Ingebrigtsen
2017-06-03 10:41   ` David Engster [this message]
2017-06-03 11:04     ` Lars Ingebrigtsen
2017-06-03 11:05     ` Eli Zaretskii
2017-06-03 12:56       ` Jerry Asher
2017-06-08 20:08         ` David Engster
2019-09-24  6:55           ` Lars Ingebrigtsen
2019-09-24  7:15             ` Eli Zaretskii
2019-09-24  7:27               ` Lars Ingebrigtsen
2019-09-24  7:23             ` David Engster
2019-09-24  7:27               ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3t9xsic.fsf@engster.org \
    --to=deng@randomsample.de \
    --cc=10478@debbugs.gnu.org \
    --cc=jerry.asher@gmail.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).