From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#29220: 26.0.90; eieio-persistent-read fail to restore saved object. Date: Sat, 16 Dec 2017 15:42:48 -0800 Message-ID: <87y3m2jl3b.fsf@ericabrahamsen.net> References: <87y3nga0lv.fsf@killashandra.ballybran.fr> <87h8tkzgef.fsf@users.sourceforge.net> <87zi76f5hj.fsf@killashandra.ballybran.fr> <87shcycavk.fsf@ericabrahamsen.net> <87lgimpdhp.fsf@ericabrahamsen.net> <87h8t8is1u.fsf@ericabrahamsen.net> <87zi6zmzh7.fsf@killashandra.ballybran.fr> <87h8t69d7b.fsf@ericabrahamsen.net> <87609lcbip.fsf@ericabrahamsen.net> <87bmjcc2rh.fsf@ericabrahamsen.net> <874lp4aije.fsf@ericabrahamsen.net> <83po7pwlgs.fsf@gnu.org> <87lgib4z2o.fsf@ericabrahamsen.net> <87wp1rcz21.fsf@users.sourceforge.net> <87mv2jkaap.fsf@killashandra.ballybran.fr> <87wp1nsk52.fsf@killashandra.ballybran.fr> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1513467676 6731 195.159.176.226 (16 Dec 2017 23:41:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Dec 2017 23:41:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: jwiegley@gmail.com, 29220@debbugs.gnu.org, monnier@iro.umontreal.ca, Noam Postavsky To: pierre.techoueyres@free.fr (Pierre =?UTF-8?Q?T=C3=A9choueyres?=) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 17 00:41:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQM4s-0001S5-Lj for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Dec 2017 00:41:10 +0100 Original-Received: from localhost ([::1]:52531 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQM6p-0005b0-5m for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Dec 2017 18:43:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQM6j-0005at-Hh for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2017 18:43:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQM6g-0006xs-Dc for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2017 18:43:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57385) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQM6g-0006xg-6c for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2017 18:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eQM6f-0006z5-PD for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2017 18:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Dec 2017 23:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29220 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 29220-submit@debbugs.gnu.org id=B29220.151346777526835 (code B ref 29220); Sat, 16 Dec 2017 23:43:01 +0000 Original-Received: (at 29220) by debbugs.gnu.org; 16 Dec 2017 23:42:55 +0000 Original-Received: from localhost ([127.0.0.1]:37833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQM6X-0006yj-Bi for submit@debbugs.gnu.org; Sat, 16 Dec 2017 18:42:55 -0500 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:42411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQM6V-0006yb-4p for 29220@debbugs.gnu.org; Sat, 16 Dec 2017 18:42:51 -0500 Original-Received: from localhost (71-212-75-109.tukw.qwest.net [71.212.75.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 872FDBBC94; Sat, 16 Dec 2017 23:42:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1513467769; bh=sCaiAzyUn0SUcB48ee4Odyr6gtS42rD832R+fXVD4zA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eX8JoMnKLTkYKrfhsBi+xunTYq/98EBZIkO3aANsCbdwqngnJi+Ks3PkSP3RcnkMg v56oaS4zFvEsFdDCawK1GFSmSlztl3FFXS2ZDtHKu0jNiUZpuUPSK0++hsQkkDEVUF 7wiF/ZsAyc5On8YIv67SmRWXNZ9AIjy6ThqKtwgk= In-Reply-To: <87wp1nsk52.fsf@killashandra.ballybran.fr> ("Pierre =?UTF-8?Q?T=C3=A9choueyres?="'s message of "Fri, 15 Dec 2017 23:26:17 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141188 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/15/17 23:26 PM, Pierre T=C3=A9choueyres wrote: > Of course with the good example and patch this will be more obvious. Oh bother, this is my fault, in c59ddb2120. The attached diff fixes this, and I guess should be put in. In #29541 I was hoping to reduce some of this complexity and make the code easier to reason about, but those changes would go into master, and this needs to be fixed in 26. More tests are definitely in order! --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=quickfix.diff diff --git a/lisp/emacs-lisp/eieio-base.el b/lisp/emacs-lisp/eieio-base.el index 0241f27395..a37cf7a1b3 100644 --- a/lisp/emacs-lisp/eieio-base.el +++ b/lisp/emacs-lisp/eieio-base.el @@ -349,7 +349,7 @@ eieio-persistent-validate/fix-slot-value (seq-some (lambda (elt) (child-of-class-p (car proposed-value) elt)) - classtype)) + (if (consp classtype) classtype (list classtype)))) (eieio-persistent-convert-list-to-object proposed-value)) (t --=-=-=--