On 12/15/17 23:26 PM, Pierre Téchoueyres wrote: > Of course with the good example and patch this will be more obvious. Oh bother, this is my fault, in c59ddb2120. The attached diff fixes this, and I guess should be put in. In #29541 I was hoping to reduce some of this complexity and make the code easier to reason about, but those changes would go into master, and this needs to be fixed in 26. More tests are definitely in order!