From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: contovob@tcd.ie, 30489@debbugs.gnu.org
Subject: bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list
Date: Fri, 16 Mar 2018 05:52:06 -0400 [thread overview]
Message-ID: <87y3isuz3t.fsf@gmail.com> (raw)
In-Reply-To: <83woycpu7f.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 16 Mar 2018 05:36:52 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Noam Postavsky <npostavs@gmail.com>
>> Date: Thu, 15 Mar 2018 22:39:18 -0400
>> Cc: 30489@debbugs.gnu.org
>>
>> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>>
>> > - `(cond ,@res (t (signal 'json-readtable-error ,char)))))
>> > + `(cond ,@res (t (signal 'json-readtable-error ,(list char))))))
>>
>> > When signalling json-readtable-error, the macro json-readtable-dispatch
>> > passes the unrecognised character as error data verbatim, rather than as
>> > a list. Attached is a patch which fixes this.
>>
>> Should this be applied to emacs-26? It seems to fix a regression
>> relative to Emacs 25 (where this error just had `nil' as the data) and
>> the patch looks safe enough.
>
> What change(s) introduced the regression?
[1: 9314e6c56e]: 2017-09-04 03:40:30 -0400
Embed JSON readtable into json-read
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9314e6c56e248a5060a6c125e2088c4fbffe123b
next prev parent reply other threads:[~2018-03-16 9:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 17:29 bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list Basil L. Contovounesios
2018-03-16 2:39 ` Noam Postavsky
2018-03-16 3:36 ` Eli Zaretskii
2018-03-16 9:52 ` Noam Postavsky [this message]
2018-03-16 14:07 ` Eli Zaretskii
2018-03-16 23:47 ` Noam Postavsky
2018-03-18 0:14 ` Basil L. Contovounesios
2018-03-18 0:25 ` Noam Postavsky
2018-03-18 14:23 ` Basil L. Contovounesios
2018-03-19 3:14 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3isuz3t.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=30489@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).