From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31312: Segmentation fault with doom-emacs, NeoTree and Zoom Date: Thu, 03 May 2018 08:21:34 -0400 Message-ID: <87y3h1lyk1.fsf@gmail.com> References: <87r2mvo6c8.fsf@gmail.com> <5AE87AA3.6050602@gmx.at> <87o9hznfam.fsf@gmail.com> <5AE957BA.6000809@gmx.at> <87fu3ant8k.fsf@gmail.com> <0DFE6C67-38C5-45EE-B658-8BEF80B595FF@gnu.org> <5AE9C062.9010203@gmx.at> <87d0ydob8z.fsf@gmail.com> <83h8nppiyb.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1525350011 31706 195.159.176.226 (3 May 2018 12:20:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 3 May 2018 12:20:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31312@debbugs.gnu.org, cyrus.and@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 03 14:20:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEDDS-00087P-K9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 May 2018 14:20:06 +0200 Original-Received: from localhost ([::1]:55962 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEDFZ-0005YH-OA for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 May 2018 08:22:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEDFN-0005Y7-IU for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 08:22:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEDFK-0003jP-DH for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 08:22:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39882) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEDFK-0003ix-Ao for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 08:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fEDFK-0005E4-4k for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 08:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 May 2018 12:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31312 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 31312-submit@debbugs.gnu.org id=B31312.152535010420059 (code B ref 31312); Thu, 03 May 2018 12:22:02 +0000 Original-Received: (at 31312) by debbugs.gnu.org; 3 May 2018 12:21:44 +0000 Original-Received: from localhost ([127.0.0.1]:47779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEDF2-0005DT-28 for submit@debbugs.gnu.org; Thu, 03 May 2018 08:21:44 -0400 Original-Received: from mail-io0-f179.google.com ([209.85.223.179]:45467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEDF0-0005DG-IQ for 31312@debbugs.gnu.org; Thu, 03 May 2018 08:21:42 -0400 Original-Received: by mail-io0-f179.google.com with SMTP id c9-v6so14999228iob.12 for <31312@debbugs.gnu.org>; Thu, 03 May 2018 05:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=GZ+uvVA2siREjXiwDr4iN4Pz3LXrV/kgqx4aL1U5K+8=; b=Bj2ujGpykWTTbpQD+uVWZuaY8YsJ2ONsy/eaFoK8sw1P/DchpCI6IpakykdNQtRZgP DvLKm+gAvcokyVaX0cEvDqmEAr3iWDps5W97OSCNSWBMQ/jYr2/2hm4/Q0YjLml+4mVk KkTlO+DwtelkZWHO5J00kn+V7aLp+ETDW6E1tnFBIvDxNEIbxeN4kzSGu5cjLfLfA1XI MDFT4e+XnGSPRqGNG11VqHabryHQM6GAMNpOKCgXzK77akjlNUxQhG13TB3qz6IdJIh9 7/dLILGjiLQcUF3Zu17qCSEL64ZkKUVkW/dHDKco2kDEfKVOj13KA4L2b34AVMlJ7FjC zFEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=GZ+uvVA2siREjXiwDr4iN4Pz3LXrV/kgqx4aL1U5K+8=; b=ZMIQSuaviHW8PlloBsuJ6R31aSpACHusvV7RUr2PSJwtIVS0Iz8l+fdScshYJkhFyw dvDRKv2qGxCLIBjPQj24v73dwviM5A3HXd1qsyEC0sLq3zsuxN26KDnqIIkKQOQ2jwP4 N1iM22TWo6vFQSlpOZxdopKb0vHWD8IMyM1KmyPkAqhPxE4cxDFHRXpgjeg8yERbxc4O VA/XdbRhagyr+Z8uwJaVZ1njoZ+ZayN+SnOXc0LgU8MYTvC1HeV/0k1acn4VUShl8zK1 udAiKJiM3ledLjEKRrnMtMsCRYvcNyJLQ1ZlGUjqbWPVJc3lobHQxbz+B68Dak3lsq0K v3sg== X-Gm-Message-State: ALQs6tDkhupDJCOp4zXvqAnH2T/3v+5W4iHLGD96Ypl/v7RjUox87YVz CHayemcd1l37V0oSB5L8Grk= X-Google-Smtp-Source: AB8JxZryBldwrLxQoDUJ1FAZHavNuR/GKl+QSIEp7s3jLNWzGZeLc4bCF63+79llFcoc2bGWxliYlQ== X-Received: by 2002:a6b:3f05:: with SMTP id m5-v6mr24516325ioa.220.1525350096958; Thu, 03 May 2018 05:21:36 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id b2-v6sm2736010itg.11.2018.05.03.05.21.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 May 2018 05:21:36 -0700 (PDT) In-Reply-To: <83h8nppiyb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 03 May 2018 05:32:44 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145964 Archived-At: Eli Zaretskii writes: > Please push to the emacs-26 branch, and thanks. Wouldn't it make sense to remove the previous check, like this? --- i/src/xdisp.c +++ w/src/xdisp.c @@ -13924,11 +13924,6 @@ redisplay_internal (void) /* Notice any pending interrupt request to change frame size. */ do_pending_window_change (true); - /* do_pending_window_change could change the selected_window due to - frame resizing which makes the selected window too small. */ - if (WINDOWP (selected_window) && (w = XWINDOW (selected_window)) != sw) - sw = w; - /* Clear frames marked as garbaged. */ clear_garbaged_frames (); @@ -13936,6 +13931,13 @@ redisplay_internal (void) if (NILP (Vmemory_full)) prepare_menu_bars (); + /* do_pending_window_change could change the selected_window due to + frame resizing which makes the selected window too small. + prepare_menu_bars may call lisp hooks and hence also change the + selected_window. */ + if (WINDOWP (selected_window) && (w = XWINDOW (selected_window)) != sw) + sw = w; + reconsider_clip_changes (w); /* In most cases selected window displays current buffer. */