From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#31357: 26.1; tramp-make-tramp-file-name: incompatible lisp changes in 26.1 ? Date: Fri, 04 May 2018 09:44:56 +0200 Message-ID: <87y3gz50g7.fsf@gmx.de> References: <0a062d8f1fea73fcead8cafe8f225378@webmail.orcon.net.nz> <87k1sksquk.fsf@gmx.de> <54c47e29d981f94a537aa9bdf0f37276@webmail.orcon.net.nz> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1525419855 15789 195.159.176.226 (4 May 2018 07:44:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 4 May 2018 07:44:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 31357@debbugs.gnu.org, bug-gnu-emacs To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 04 09:44:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEVNy-000429-Lp for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 May 2018 09:44:10 +0200 Original-Received: from localhost ([::1]:32870 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEVQ5-0004sT-H9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 May 2018 03:46:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEVPs-0004r5-3r for bug-gnu-emacs@gnu.org; Fri, 04 May 2018 03:46:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEVPm-0002SJ-Fu for bug-gnu-emacs@gnu.org; Fri, 04 May 2018 03:46:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40936) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEVPm-0002S7-Bm for bug-gnu-emacs@gnu.org; Fri, 04 May 2018 03:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fEVPl-0005k4-Qc for bug-gnu-emacs@gnu.org; Fri, 04 May 2018 03:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 May 2018 07:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31357-submit@debbugs.gnu.org id=B31357.152541991619129 (code B ref 31357); Fri, 04 May 2018 07:46:01 +0000 Original-Received: (at 31357) by debbugs.gnu.org; 4 May 2018 07:45:16 +0000 Original-Received: from localhost ([127.0.0.1]:48833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEVP2-0004y8-HR for submit@debbugs.gnu.org; Fri, 04 May 2018 03:45:16 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:49065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEVP0-0004q1-3c for 31357@debbugs.gnu.org; Fri, 04 May 2018 03:45:14 -0400 Original-Received: from detlef.gmx.de ([212.86.52.157]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0McEkx-1ewh023NCR-00JWzr; Fri, 04 May 2018 09:44:57 +0200 In-Reply-To: <54c47e29d981f94a537aa9bdf0f37276@webmail.orcon.net.nz> (Phil Sainty's message of "Fri, 04 May 2018 09:34:47 +1200") X-Provags-ID: V03:K1:DeZaO5gmsEnbJdfT2aOqXwgOBh8OgGIQ5e9uqfumNGy1qODJJ6E E9TGfbdcM1WYRgiVdrRFaUXS1lFno1BAvdH18EzO9U06eGXJ5Ds78iaVwXsSUDBJB+kAhwb YlHuCyHJGBymOsjS/LovcjnxkYklAukaf1IBeDdTRE1vD47p50OvaxwpVd4EenwObUttrbT KR4S+3E7wxC4RaKnXU4PA== X-UI-Out-Filterresults: notjunk:1;V01:K0:OgI51Gf4p6E=:23r2gc38R22cK6VLGUJauJ 2otm2q7DotUYWEY0cPQUUY7Gp/qTKyrmyJM2jmnXcL33tP1cUA9yM1Yaow9aOjdZRhplp/moR xDJphwY0s57sscxWvVn1KremL+u4yQEPeuRhpxGK0mY/Qn3uSxp2x203AyG7jE8MXI33+FlGs CwNunNmn3SBRHHDLOj2RDL0dKMyeLTfx/fe7KDwjVgYEtxEEgUif4T9yTNhRCNEkjfFQni7m3 GBJGcEIvrHiJJEM6ys3LOjqp648/96fCggWcn9stToj/o4quKIEMWl75tp5wunPVvkq5YItd4 C2x3QfwPxxKrN1EOeZt5W7KWZfX1iVAqNPACQUl/76uKzxbAlLyKIbkxCuerqfSLWX1D3GDxK kZrsrKQ5aQZtDJjBHNT8ByqssEoCuZx98EtfoeBfW45x2Ir9t4jqoZli+kB+VOm6H/XmXspJS K8CHfgWXZUdQtY4sFGIo5qZEkGxc8F0jR5FnpStCUQe2vXhgjW4pQNGdnmqLz/HwPEwN86b8F Bf7TZsNMmUK6QC5yK77nfvWCS3xiVjWHNFMgKHwsnTwB9B2HusQbv59f2fpY0aY9zTlXlu0uI J9zO/reRTTJrZ5qCF3ZXyGaObmgbGr2P1VpvBrd2NoD5WmkoOImLUyxT13bC4LYhP50AjD4Nj DsrbZegCmynfHKJA/K8PzeHnMX9SSkeitXp1oA5cHNuIyNbyW/KxkB/7+c2aUL4Mu/i6BIqbL LWPiazMwuxDxuwjvxMq2Gna0xiLmFJ8zwrkg/am3vWr5uSI+WpM/G0mb4SHLyzdMqygCLLTP X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146003 Archived-At: Phil Sainty writes: Hi Phil, >> `tramp-make-tramp-file-name' has never been documented as public >> function, it is intended for internal use. Granted, this should have >> been signalled better. > > Given the function naming, a NEWS entry seems warranted to me. Well, this is a historical accident. None of the Tramp functions has been indicated as internal (as a double slash in the function name would do). This was already the case when I've entered the Tramp team back in 2002. And later on I resisted to perform a big renaming just for this. > I do think that there *should* be a public interface for manipulating > tramp file names. If these were never intended as such then perhaps > such functionality could be introduced... Perhaps. These days, people dissect a remote file name by the different calls of `file-remote-p', and reconstruct the file name by `concat' or `format'. An public interface might help. But this won't be `tramp-make-tramp-file-name', because this is the internal working horse, which will always be adapted to whatever need arrives in Tramp. Maybe you could propose such a public interface? It shouldn't be Tramp specific, other file name handlers shall profit from this as well. And local file names as arguments shall also be possible, so that you could change a local file name into a remote file name by a simple call (think about the common case changing a local file name into a sudo'ed one). See also function `file-local-name' (introduced in Emacs 26.1), which could be part of such broader interface. >> (setf (tramp-file-name-host vec) "whatever") > > Ah, I'd actually tried that in 25.2 but those are not generalized > variables in that version. I see that it works in 26.1 though, > so that's an excellent enhancement. Well, `tramp-file-name' has been introduced as defstruct in Tramp 2.3. Before, there was no dedicated type, and VEC was always a, hmm, simple vector. > cheers, > -Phil Best regards, Michael.