From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.bugs Subject: bug#31311: 27.0; doc of `pcase' Date: Mon, 21 May 2018 19:04:53 +0200 Message-ID: <87y3gd0wju.fsf@gnuvola.org> References: Reply-To: 31311@debbugs.gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1527053294 7447 195.159.176.226 (23 May 2018 05:28:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 23 May 2018 05:28:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: 31311@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 23 07:28:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLMJl-0001pr-RR for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 May 2018 07:28:09 +0200 Original-Received: from localhost ([::1]:59306 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLMLp-00072r-TP for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 May 2018 01:30:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLMLg-00071j-8B for bug-gnu-emacs@gnu.org; Wed, 23 May 2018 01:30:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLMLb-00046q-P6 for bug-gnu-emacs@gnu.org; Wed, 23 May 2018 01:30:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36763) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fLMLb-00046k-KZ for bug-gnu-emacs@gnu.org; Wed, 23 May 2018 01:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fLMLb-0001XD-EI for bug-gnu-emacs@gnu.org; Wed, 23 May 2018 01:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thien-Thi Nguyen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 May 2018 05:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31311 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31311-submit@debbugs.gnu.org id=B31311.15270533635810 (code B ref 31311); Wed, 23 May 2018 05:30:03 +0000 Original-Received: (at 31311) by debbugs.gnu.org; 23 May 2018 05:29:23 +0000 Original-Received: from localhost ([127.0.0.1]:44659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLMKx-0001VZ-AU for submit@debbugs.gnu.org; Wed, 23 May 2018 01:29:23 -0400 Original-Received: from mail.agora-net.com ([67.59.132.6]:41919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLMKu-0001VJ-0q for 31311@debbugs.gnu.org; Wed, 23 May 2018 01:29:20 -0400 Original-Received: from ttn by mail.agora-net.com with local (Exim 4.82) (envelope-from ) id 1fLMKs-000180-U4; Wed, 23 May 2018 01:29:19 -0400 Original-Received: from ttn by zigzag.favinet with local (Exim 4.80) (envelope-from ) id 1fKoF7-0006dg-Cl; Mon, 21 May 2018 19:05:05 +0200 Mail-Followup-To: 31311@debbugs.gnu.org In-Reply-To: (Drew Adams's message of "Sun, 29 Apr 2018 09:03:32 -0700 (PDT)") X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: ttn@gnuvola.org X-SA-Exim-Scanned: No (on mail.agora-net.com); SAEximRunCond expanded to false X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146414 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable () Drew Adams () Sun, 29 Apr 2018 09:03:32 -0700 (PDT) [points 1. through 15.] I have just pushed branches: fix/bug-31311-pcase-docs fix/bug-31311-pcase-docs-squash that address these points (and others raised during discussion). The latter branch is the former, squashed, and additionally rebased off =E2=80=98emacs-26=E2=80=99. Here are the four commits, briefly: 25d3e50 Ensure pcase doc shows `QPAT first among extensions 62b1cef Introduce EXPVAL for pcase, pcase-defmacro docstrings a7bf9ce Use EXPVAL in docstrings of patterns defined using pcase-defmacro 2df20b3 Overhaul pcase documentation (The first is mostly independent of this bug, and so its commit message lacks the "(Bug#31311)" found in the others'.) 16. All of the following text in the _doc string_ is pretty much incomprehensible, to me. [...] Yeah, i was also flummoxed for a bit. The third commit touches many of these docstrings, the ones that i could decipher. Its changes do not improve the meaning too much, i'm afraid (but at least, now they are more consistent in one syntax aspect). -- `QPAT This particular extension is actually "built-in" in spirit. The first commit takes care to support that impression (somewhat). The other commits improve its docstring, i believe. The -squash branch is ready for merge. I'll wait a few days for comments and do the merge, unless someone beats me to it. Once merged, i'd like to reserve the right to delete those branches (personal closure :-D), if the maintainers don't mind. =2D-=20 Thien-Thi Nguyen ----------------------------------------------- (defun responsep (query) (pcase (context query) (`(technical ,ml) (correctp ml)) ...)) 748E A0E8 1CB8 A748 9BFA =2D-------------------------------------- 6CE4 6703 2224 4C80 7502 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlsC/DkACgkQZwMiJEyAdQJjEwCfXRgZDczFoHOA3+nZ1WbH+R7E zAoAn0h3lSaRlsjzBJ2r7tMf5Oxs0SfC =yBmn -----END PGP SIGNATURE----- --=-=-=--