From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32257: 26.1; read-multiple-choice inf loops on mouse clicks Date: Wed, 25 Jul 2018 21:25:46 -0400 Message-ID: <87y3dy3i05.fsf@gmail.com> References: <87muug4z52.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1532568379 5711 195.159.176.226 (26 Jul 2018 01:26:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 26 Jul 2018 01:26:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: lars ingebrigtsen , andy moreton To: 32257@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 26 03:26:15 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiV2k-0001Mc-Lp for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Jul 2018 03:26:14 +0200 Original-Received: from localhost ([::1]:57206 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fiV4r-00081P-HA for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Jul 2018 21:28:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fiV3Z-0007Ri-Vi for bug-gnu-emacs@gnu.org; Wed, 25 Jul 2018 21:27:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fiV3X-0000NG-03 for bug-gnu-emacs@gnu.org; Wed, 25 Jul 2018 21:27:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52883) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fiV3W-0000NA-Pq for bug-gnu-emacs@gnu.org; Wed, 25 Jul 2018 21:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fiV3W-0001wg-FA for bug-gnu-emacs@gnu.org; Wed, 25 Jul 2018 21:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Jul 2018 01:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32257-submit@debbugs.gnu.org id=B32257.15325683637399 (code B ref 32257); Thu, 26 Jul 2018 01:27:02 +0000 Original-Received: (at 32257) by debbugs.gnu.org; 26 Jul 2018 01:26:03 +0000 Original-Received: from localhost ([127.0.0.1]:57901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiV2V-0001uw-D0 for submit@debbugs.gnu.org; Wed, 25 Jul 2018 21:26:03 -0400 Original-Received: from mail-io0-f172.google.com ([209.85.223.172]:37846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiV2P-0001ud-TH for 32257@debbugs.gnu.org; Wed, 25 Jul 2018 21:25:58 -0400 Original-Received: by mail-io0-f172.google.com with SMTP id z19-v6so54200ioh.4 for <32257@debbugs.gnu.org>; Wed, 25 Jul 2018 18:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OGevfoWQMzyqkflxcsymKQyqYoJntqeY4Wc1vt/wtoQ=; b=AeShoWjcTM7KnqHPSwmPOFHCkRxWiv5tL213dhuDZUrAiGT0NbGeJ64SqKNoDOjITF toNK0CSr0YeMQrdbSENPbi2e1hlNcxhWFum6aLJqGf7lqMHmi00ZKcXGTSJF8eiQ/ZTQ 5lvtk3D0iscPSsoVWqKCJbvE+/S1s8/kvExnAfBN1rwR4u2aEycvFJzg8pbOi6gTNTAu WUDZYJcIvM/o1Bberx+HrhpEEqah8G50rkFGTzOtwhIK6YmTLzRZowuu9xaa114ui41J jXbaKotQzcFZk/9RiIKH38FjOhZbi14YJeE/NURBCsRO+vRFAHBTcC7JnKa1mmpehuZX u8Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OGevfoWQMzyqkflxcsymKQyqYoJntqeY4Wc1vt/wtoQ=; b=S4GDSdqvEZee/l5zAqsml7SclMkySBp7OGiTTQqVuFhAc7/jsAwBMu6tgEQj9pNogC bdIyTCDJX0BMYBAppztsD8Y057Fj/hlcx8gCfSj00V3R3NMkRpWBH0PfCSI5EZcbk0jN 2Koa3TuSVYsSNEPlur5kXO2VrZAhLhaG704nVHxVhfdimHtL/hyUP2c38Rtb6dW64skl JPRdpVfVXsMXxF+LvqoaNSUT+I5YsJUC+pmGeV9mJhKwaxeasKnj9su6EDiKY1oeaVcu V66Y69+/KwcqDV0tFkoqbBgVBOkU4N27/qZOlAXqqkwcJlhlzygMw8jKCD7OYrqLzMs8 xWgg== X-Gm-Message-State: AOUpUlEQNMrBVJ9Fh/mRW69IkFmvS7UEADarlnzBFXEehUPYGjqQNVDA mox+HJYJ+O/259jx6tfBM1E= X-Google-Smtp-Source: AAOMgpdGmqkjl3DEp4kdVebFtyCmPq0C0Nlxpx5bHY4WuGAzsIRs7pMDv2z31J31Zs4srJfBHSqm0A== X-Received: by 2002:a6b:dd01:: with SMTP id f1-v6mr18756836ioc.45.1532568348422; Wed, 25 Jul 2018 18:25:48 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i13-v6sm1591960iog.31.2018.07.25.18.25.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Jul 2018 18:25:47 -0700 (PDT) In-Reply-To: <87muug4z52.fsf@gmail.com> (Noam Postavsky's message of "Tue, 24 Jul 2018 08:05:45 -0400") X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148944 Archived-At: Noam Postavsky writes: > X-Debbugs-CC: Andy Moreton , Lars Ingebrigtsen > > Starting from emacs -Q, evaluate: > > (require 'rmc) > (read-multiple-choice "choice? " '((?a "ay") (?b "bee") (?c "see"))) > > then click the mouse somewhere instead of answering the prompt, notice > Emacs maxing out CPU, hit C-g. *Messages* will have a log of the prompt > being repeated many times: > > choice? (ay, bee, [c] see, ?): [4435 times] The problem seems to be that read-char doesn't "use up" non-character events, e.g., with the following: (defun read-char-or-err () (condition-case err (read-char) (error err))) (list (read-char-or-err) (read-char-or-err) (read-char-or-err) (read-char-or-err) (read-char-or-err)) this returns ((error "Non-character input-event") (error "Non-character input-event") ...) regardless of how many calls to read-char-or-err there are. The patch below fixes the inf looping, although it still doesn't allow any other user interaction (unlike read-from-minibuffer). --- i/lisp/emacs-lisp/rmc.el +++ w/lisp/emacs-lisp/rmc.el @@ -118,8 +118,10 @@ read-multiple-choice choices))) (condition-case nil (let ((cursor-in-echo-area t)) - (read-char)) + (read-event)) (error nil)))) + (unless (characterp tchar) + (setq tchar nil)) (setq answer (lookup-key query-replace-map (vector tchar) t)) (setq tchar (cond