From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#32607: 27.0.50; pop-to-buffer in next-error-no-select Date: Fri, 14 Sep 2018 02:04:08 +0300 Organization: LINKOV.NET Message-ID: <87y3c5ov87.fsf@mail.linkov.net> References: <87a7p0alxv.fsf@mail.linkov.net> <5B8B8DCE.4070704@gmx.at> <87efebjzbd.fsf@mail.linkov.net> <5B8CE360.5030700@gmx.at> <877ek2tdqx.fsf@mail.linkov.net> <5B8E3998.3050907@gmx.at> <87o9ddc8yc.fsf@mail.linkov.net> <5B8F8A1B.3030807@gmx.at> <8736unzjit.fsf@mail.linkov.net> <5B90D17D.5080605@gmx.at> <87efe6iaws.fsf@mail.linkov.net> <5B9228A3.4020700@gmx.at> <87sh2j36jw.fsf@mail.linkov.net> <5B94DC6C.6090107@gmx.at> <5B9A15C4.5010905@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1536880893 16845 195.159.176.226 (13 Sep 2018 23:21:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 13 Sep 2018 23:21:33 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 32607@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 14 01:21:29 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0avO-0004Eg-LV for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Sep 2018 01:21:26 +0200 Original-Received: from localhost ([::1]:45869 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0axV-0007qB-3Z for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Sep 2018 19:23:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0axH-0007oM-If for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 19:23:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g0ax5-00065I-Pg for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 19:23:20 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35536) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g0aww-0005oz-L2 for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 19:23:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g0aww-00029v-Ey for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 19:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Sep 2018 23:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32607 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32607-submit@debbugs.gnu.org id=B32607.15368809228184 (code B ref 32607); Thu, 13 Sep 2018 23:23:02 +0000 Original-Received: (at 32607) by debbugs.gnu.org; 13 Sep 2018 23:22:02 +0000 Original-Received: from localhost ([127.0.0.1]:39791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0avx-00027p-Tp for submit@debbugs.gnu.org; Thu, 13 Sep 2018 19:22:02 -0400 Original-Received: from pop.dreamhost.com ([64.90.62.162]:57470 helo=pdx1-sub0-mail-a31.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0avw-00027b-2g for 32607@debbugs.gnu.org; Thu, 13 Sep 2018 19:22:00 -0400 Original-Received: from pdx1-sub0-mail-a31.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTP id EBD7A7F977; Thu, 13 Sep 2018 16:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=6E6gMgAjBmmLluqyUZHb2qlJY1Y=; b= zTkyoGLmQAajVn4UXmo2iFrck/YCZEdiMhO5ivF0WRoQy43Z1p+Ravd919CMjK8m wUSHBSnuKAQjftJbgP4lkJ/NrcbcHyAgrbkJWm/4dbhLKCWOfT/8uylru8lqFEHN XMunrRHIvOwiAzWPvHRrXOSe/KkQhhjWhTqJZ3Vl8wY= Original-Received: from localhost.linkov.net (m91-129-104-147.cust.tele2.ee [91.129.104.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTPSA id B15BA7F6F6; Thu, 13 Sep 2018 16:21:57 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a31 X-DH-BACKEND: pdx1-sub0-mail-a31 In-Reply-To: (Stefan Monnier's message of "Thu, 13 Sep 2018 07:26:50 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150302 Archived-At: >>> BTW, it's not just a question of selection: "display the locus buffer" >>> may also hide the source buffer, hence the need for the subsequent >>> pop-to-buffer. >> ... which may then hide the locus buffer. > > Indeed. I guess for this reason next-error-no-select might want to > let-bind display-buffer-overriding-action to something like > (nil (inhibit-same-window . t)) during the call to next-error. Then the same overriding should be applied to both: diff --git a/lisp/simple.el b/lisp/simple.el index ffd7fcc067..17ebcb2e16 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -383,9 +383,10 @@ next-error-no-select Finds and highlights the source line like \\[next-error], but does not select the source buffer." (interactive "p") - (let ((next-error-highlight next-error-highlight-no-select)) + (let ((next-error-highlight next-error-highlight-no-select) + (display-buffer-overriding-action '(nil (inhibit-same-window . t)))) (next-error n)) - (let ((display-buffer-overriding-action '(display-buffer-reuse-window))) + (let ((display-buffer-overriding-action '(nil (inhibit-same-window . t)))) ;; Override user customization such as display-buffer-same-window ;; and use display-buffer-reuse-window to ensure next-error-last-buffer ;; is displayed somewhere, not necessarily in the same window (bug#32607). (pop-to-buffer next-error-last-buffer)