bug#34986: write-region not governed by require-final-newline

bug#34986: write-region not governed by require-final-newline

[積丹尼 Dan Jacobson]

User, despite setting
 require-final-newline t
in .emacs, still finds he is often creating files without final
newlines.

It turns out write-region, which he often uses, is not governed by
require-final-newline.

I though the whole logic of require-final-newline was to help people add
those newlines.

bug#34986: write-region not governed by require-final-newline

[Basil L. Contovounesios]

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> User, despite setting
>  require-final-newline t
> in .emacs, still finds he is often creating files without final
> newlines.
>
> It turns out write-region, which he often uses, is not governed by
> require-final-newline.
>
> I though the whole logic of require-final-newline was to help people add
> those newlines.

The user option require-final-newline is relevant only when visiting
files, not when writing to arbitrary ones, so you probably want to use
save-buffer instead of write-region or similar.

See (info "(emacs) Visiting"), (info "(emacs) Customize Save"), and
(info "(elisp) Saving Buffers").

-- 
Basil

bug#34986: write-region not governed by require-final-newline

[積丹尼 Dan Jacobson]

>>>>> "BLC" == Basil L Contovounesios <contovob@tcd.ie> writes:

BLC> The user option require-final-newline is relevant only when visiting
BLC> files, not when writing to arbitrary ones,

OK, but perhaps add a note about that somewhere on the docstring:

require-final-newline...
Documentation:
Whether to add a newline automatically at the end of the file.

A value of t means do this only when the file is about to be saved.
A value of ‘visit’ means do this right after the file is visited.
A value of ‘visit-save’ means do it at both of those times.
Any other non-nil value means ask user whether to add a newline, when saving.
A value of nil means don’t add newlines.

bug#34986: write-region not governed by require-final-newline

[Lars Ingebrigtsen]

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

>>>>>> "BLC" == Basil L Contovounesios <contovob@tcd.ie> writes:
>
> BLC> The user option require-final-newline is relevant only when visiting
> BLC> files, not when writing to arbitrary ones,
>
> OK, but perhaps add a note about that somewhere on the docstring:
>
> require-final-newline...
> Documentation:
> Whether to add a newline automatically at the end of the file.

I've now added text to the doc string to mention this.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no