From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) Date: Tue, 09 Apr 2019 20:16:36 -0700 Message-ID: <87y34iim7f.fsf@ericabrahamsen.net> References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> <87imvmbube.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="185944"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34776-done@debbugs.gnu.org To: 34776@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 10 05:17:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hE3jf-000mEC-42 for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Apr 2019 05:17:15 +0200 Original-Received: from localhost ([127.0.0.1]:52706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE3jd-0004D7-Nx for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Apr 2019 23:17:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE3jV-0004CE-0d for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 23:17:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hE3jT-0007D7-UG for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 23:17:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38727) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hE3jT-00078y-0k for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 23:17:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hE3jS-0003TG-Lo for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 23:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Apr 2019 03:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34776 X-GNU-PR-Package: emacs Original-Received: via spool by 34776-submit@debbugs.gnu.org id=B34776.155486620513312 (code B ref 34776); Wed, 10 Apr 2019 03:17:01 +0000 Original-Received: (at 34776) by debbugs.gnu.org; 10 Apr 2019 03:16:45 +0000 Original-Received: from localhost ([127.0.0.1]:52271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE3jB-0003SZ-FU for submit@debbugs.gnu.org; Tue, 09 Apr 2019 23:16:45 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:49500 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hE3j9-0003SG-D7; Tue, 09 Apr 2019 23:16:44 -0400 Original-Received: from localhost (97-113-35-98.tukw.qwest.net [97.113.35.98]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 70DABFA028; Wed, 10 Apr 2019 03:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554866197; bh=qw/zFDhEc+WaIovIkG1vzsPrLtbY/RmbrURGaCb3p9A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=qcS9hukP4gpts0+PgPkmpYJKkHsfJADg9SCY2jraTD/10ySIAd5DDldf7jP6Yuws+ lAm3dHVX+dA590GdsCDYo0QaCBUVUv5Ps3rQMWzWRSTkasE0uh3kymCthFUMJ+QQ/H N28AU91f6pb5Y7dBnrNBlHY2SJlaW4NQyYvSM/l0= In-Reply-To: <87imvmbube.fsf@gmail.com> (Noam Postavsky's message of "Tue, 09 Apr 2019 20:03:17 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157444 Archived-At: Noam Postavsky writes: > Eric Abrahamsen writes: > >> So never mind! But I'd still like to add something like the attached, as >> functions following the current docstring will raise an error. >> >> Eric >> >> diff --git a/lisp/simple.el b/lisp/simple.el >> index d4ae5ebb1f..0274bdb459 100644 >> --- a/lisp/simple.el >> +++ b/lisp/simple.el >> @@ -8188,6 +8188,9 @@ choose-completion-string-functions >> BUFFER - the buffer in which the choice should be inserted, >> BASE-POSITION - where to insert the completion. >> >> +Functions should also accept and ignore a potential fourth >> +argument, passed for backwards compatibility. >> + > > Looks good to me. And it can go to emacs-26 since it's a doc fix. Done, thanks. Welcome back! E