From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#35389: 27.0.50; [PATCH] Emacs on macOS sets mouse-wheel variables directly Date: Tue, 23 Apr 2019 07:17:24 -0400 Message-ID: <87y341q8cb.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="256941"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 35389@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 23 13:18:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hItRF-0014ih-Qw for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2019 13:18:13 +0200 Original-Received: from localhost ([127.0.0.1]:51915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hItRE-0006C8-P7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2019 07:18:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hItR6-0006Bx-FJ for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 07:18:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hItR5-0004RS-0j for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 07:18:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39015) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hItR4-0004RG-IL for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 07:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hItR4-0001x4-7W for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 07:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Apr 2019 11:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35389 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35389-submit@debbugs.gnu.org id=B35389.15560182557466 (code B ref 35389); Tue, 23 Apr 2019 11:18:02 +0000 Original-Received: (at 35389) by debbugs.gnu.org; 23 Apr 2019 11:17:35 +0000 Original-Received: from localhost ([127.0.0.1]:52559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hItQd-0001wM-LH for submit@debbugs.gnu.org; Tue, 23 Apr 2019 07:17:35 -0400 Original-Received: from mail-qt1-f174.google.com ([209.85.160.174]:43295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hItQa-0001w6-DQ for 35389@debbugs.gnu.org; Tue, 23 Apr 2019 07:17:32 -0400 Original-Received: by mail-qt1-f174.google.com with SMTP id i14so15515616qtr.10 for <35389@debbugs.gnu.org>; Tue, 23 Apr 2019 04:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=HsMQEkNFq7N7CMLBPujt3Kq+07lzyLbqPnaGbWGGnbU=; b=ZvuFpnk2s1mUI6sBXc6rHu5IhzLss7a42sSPb2ORzlFpxhxMuhFQwurIaEKgTTWlsI qrYkKhx6BFLFivigCjRmD9yycqjChGMT31pPdgV4njbFaOEEsIdb9BVlfejQaJUxVAk1 qjCDC/L3rU13+eugrtAAUQ7qCXvefmytPs5l8XFyHuk38YYbJuPHxrHrPK+uxzZSL2Us jy8Cm2OtE7PNoTXFWxoTNecrMRBG7CZWxR0A62tvpHtpeXzTLD9wBDUL6YI+T01ZMyoT 8GN73Sn5QbVz+PP4AjN+iV5ALapQbH6k2B2O0lVt04uZ1HkCTRx3ocxJ8zchwIGOsu8A zBfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=HsMQEkNFq7N7CMLBPujt3Kq+07lzyLbqPnaGbWGGnbU=; b=T8jL9FLjACj/zn7KtZmyOQZKxkzLGjMRbMLTC7QCdEcUUoNZ2ohDNMbQL5foqal/Vx SR8nMYBGgo19EsLP2nUcwKIALgOKtU5eXXnYK4+NAxNaWnkp3HoNecpx9JrFR7rsGkeR aoPtySdQykF3oVc+I+4vO8XVSjmvqouFRK+i2EehIGR3Ag3E1SHH7WHis6uUyl3K7Niw DHG6Y/MvB5ZxF8vw6SN9+PNo3zrUCtyza2A1GoL24M70Gn8MFES7hZEwoUbEwX3mDLiE S+3zveuwYWdZj4wWfxcCulsb+TnlWu0ncrvDkQK2Fk3/m3wKXBwR9XmK26w+do1udpSn d93w== X-Gm-Message-State: APjAAAVOjNO2MP3wMaPFEsaWWlgf+J0h95DWcXXMiCMkzX+eIPJXBS+T GgLJj3WhtlL1T5yj/tk51ajXNppx X-Google-Smtp-Source: APXvYqxaGQvZUiTyRgSw0VwSFgsx+MA/+5zdwab2uo7/wI0hSfo8UHStMurcyicMSyIGSRoO823MHw== X-Received: by 2002:ac8:6bc2:: with SMTP id b2mr10777557qtt.316.1556018246764; Tue, 23 Apr 2019 04:17:26 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id u3sm7462466qkc.21.2019.04.23.04.17.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Apr 2019 04:17:25 -0700 (PDT) In-Reply-To: (Robert Pluim's message of "Tue, 23 Apr 2019 11:47:43 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158118 Archived-At: Robert Pluim writes: > I use the cus-edit+ package, which prompts you to save unsaved > customizations when you exit emacs. This triggers for me all the time, > because lisp/term/ns-win.el does 'setq' on mouse-wheel-scroll-amount > and mouse-wheel-progressive-speed, which I think is a no-no. The patch > below fixes it for me, but I=CA=BCm utterly ignorant of customize, so > perhaps it=CA=BCs not the correct fix. I think it should work to change customized-value to standard-value. --- i/lisp/term/ns-win.el +++ w/lisp/term/ns-win.el @@ -746,11 +746,11 @@ (when (featurep 'cocoa) ;; Appkit 1138 ~=3D macOS 10.7. (when (>=3D appkit-version 1138) (setq mouse-wheel-scroll-amount '(1 ((shift) . 5) ((control)))) - (put 'mouse-wheel-scroll-amount 'customized-value + (put 'mouse-wheel-scroll-amount 'standard-value (list (custom-quote (symbol-value 'mouse-wheel-scroll-amount)))) =20 (setq mouse-wheel-progressive-speed nil) - (put 'mouse-wheel-progressive-speed 'customized-value + (put 'mouse-wheel-progressive-speed 'standard-value (list (custom-quote (symbol-value 'mouse-wheel-progressive-speed)))))))