unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#35724: [PATCH] OpenVPN password prompts are not recognized by comint.el
@ 2019-05-13 22:56 mjbauer95
  2019-05-24 11:33 ` Noam Postavsky
  0 siblings, 1 reply; 2+ messages in thread
From: mjbauer95 @ 2019-05-13 22:56 UTC (permalink / raw)
  To: 35724

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

 OpenVPN has a password prompt that is a little different than is
 handled by comint.el. It looks like this:
 
  Enter Auth Password:

 As a result, the plain text password is chown when entering in through
 shell-mode. The attached patch adds to ‘comint-password-prompt-regexp’
 handling for this case.

 

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-Enter-Auth-prompt-handling-for-OpenVPN-prompts.patch --]
[-- Type: text/x-patch, Size: 1057 bytes --]

From 09adfe3c413ee75aa1f31548907d9d1a7c6b6e6b Mon Sep 17 00:00:00 2001
From: Matthew Bauer <mjbauer95@gmail.com>
Date: Mon, 13 May 2019 18:39:32 -0400
Subject: [PATCH] =?UTF-8?q?Add=20=E2=80=9CEnter=20Auth=E2=80=9D=20prompt?=
 =?UTF-8?q?=20handling=20for=20OpenVPN=20prompts?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

OpenVPN prompts look like:

  Enter Auth Password:

This adds handling for that in comint-password-prompt-regexp.
---
 lisp/comint.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/comint.el b/lisp/comint.el
index d21cc1378f..3dce1c9c8d 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -356,7 +356,7 @@ This variable is buffer-local."
    "\\(^ *\\|"
    (regexp-opt
     '("Enter" "enter" "Enter same" "enter same" "Enter the" "enter the"
-      "Old" "old" "New" "new" "'s" "login"
+      "Enter Auth" "Old" "old" "New" "new" "'s" "login"
       "Kerberos" "CVS" "UNIX" " SMB" "LDAP" "PEM" "SUDO"
       "[sudo]" "Repeat" "Bad" "Retype")
     t)
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#35724: [PATCH] OpenVPN password prompts are not recognized by comint.el
  2019-05-13 22:56 bug#35724: [PATCH] OpenVPN password prompts are not recognized by comint.el mjbauer95
@ 2019-05-24 11:33 ` Noam Postavsky
  0 siblings, 0 replies; 2+ messages in thread
From: Noam Postavsky @ 2019-05-24 11:33 UTC (permalink / raw)
  To: mjbauer95; +Cc: 35724

tags 35724 fixed
close 35724 27.1
quit

mjbauer95@gmail.com writes:

>  OpenVPN has a password prompt that is a little different than is
>  handled by comint.el. It looks like this:
>  
>   Enter Auth Password:
>
>  As a result, the plain text password is chown when entering in through
>  shell-mode. The attached patch adds to ‘comint-password-prompt-regexp’
>  handling for this case.

Pushed to master.

f6d3005069 2019-05-24T07:33:01-04:00 "Add "Enter Auth" prompt handling for OpenVPN (Bug#35724)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f6d3005069551f3ed5817078a095b868007bf12d






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-24 11:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-13 22:56 bug#35724: [PATCH] OpenVPN password prompts are not recognized by comint.el mjbauer95
2019-05-24 11:33 ` Noam Postavsky

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).