From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#33937: 26.1; mhtml-mode fails to capture font-lock-keywords-case-fold-search Date: Thu, 31 Oct 2019 14:08:34 +0100 Message-ID: <87y2x1kqp9.fsf@gnus.org> References: <87mudiowzv.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="110435"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33937@debbugs.gnu.org, Leo Liu To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 31 14:09:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQACW-000SSV-52 for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Oct 2019 14:09:20 +0100 Original-Received: from localhost ([::1]:49996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQACU-0006yt-RY for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Oct 2019 09:09:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34275) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQACH-0006ri-4k for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 09:09:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQACF-0007Qm-GN for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 09:09:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43402) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQACE-0007Px-N3 for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 09:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQACE-0007g2-GB for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 09:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Oct 2019 13:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33937 X-GNU-PR-Package: emacs Original-Received: via spool by 33937-submit@debbugs.gnu.org id=B33937.157252732229470 (code B ref 33937); Thu, 31 Oct 2019 13:09:02 +0000 Original-Received: (at 33937) by debbugs.gnu.org; 31 Oct 2019 13:08:42 +0000 Original-Received: from localhost ([127.0.0.1]:52220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQABt-0007fG-MR for submit@debbugs.gnu.org; Thu, 31 Oct 2019 09:08:41 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:45274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQABs-0007f6-Hb for 33937@debbugs.gnu.org; Thu, 31 Oct 2019 09:08:41 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQABn-0000XT-Dd; Thu, 31 Oct 2019 14:08:37 +0100 In-Reply-To: (Stefan Monnier's message of "Wed, 30 Oct 2019 17:19:00 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170505 Archived-At: Stefan Monnier writes: >> ;; Case fold during regexp fontification? >> - (when (nth 2 defaults) >> - (set (make-local-variable 'font-lock-keywords-case-fold-search) t)) >> + (if (nth 2 defaults) >> + (set (make-local-variable 'font-lock-keywords-case-fold-search) t) >> + (kill-local-variable 'font-lock-keywords-case-fold-search)) >> >> It's slightly puzzling -- font-lock-keywords-case-fold-search is >> permanently buffer-local, but I guess that puzzlement was there before >> this patch, but the kill-local-variable thing is what makes mhtlm not >> work. >> >> Stefan, do you remember the reason for this change? > > I can't remember the specific case, but I remember that it was basically > the inverse situation where font-lock-keywords-case-fold-search was left > at `t` instead of resetting it to the default nil. > > I guess we should just > > (setq-local font-lock-keywords-case-fold-search (nth 2 defaults)) > > instead, I've now done this change, which should fix the reported problem. But I'm slightly worried that this may have some impact if there's a global setting somewhere that should be respected... Not for font-lock-keywords-case-fold-search (which is always buffer-local), but for font-lock-syntax-table and font-lock-keywords-only. Hm... perhaps I should have left those two alone, although it seems odd to treat them differently... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no