From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#24012: 25.0.95; forward-comment backwards takes O(n^2) Date: Fri, 08 Nov 2019 04:59:14 +0100 Message-ID: <87y2wruigd.fsf@marxist.se> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="143242"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 24012-done@debbugs.gnu.org, Leo Liu To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 08 05:00:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iSvRU-000b6T-Oi for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Nov 2019 05:00:13 +0100 Original-Received: from localhost ([::1]:49598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSvRT-0006il-JG for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Nov 2019 23:00:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38365) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSvRN-0006ic-P2 for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2019 23:00:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSvRM-0001r0-Jn for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2019 23:00:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35540) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSvRM-0001qn-FW for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2019 23:00:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iSvRM-00066C-B1 for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2019 23:00:04 -0500 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Nov 2019 04:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 24012 X-GNU-PR-Package: emacs Mail-Followup-To: 24012@debbugs.gnu.org, stefan@marxist.se, sdl.web@gmail.com Original-Received: via spool by 24012-done@debbugs.gnu.org id=D24012.157318556423260 (code D ref 24012); Fri, 08 Nov 2019 04:00:02 +0000 Original-Received: (at 24012-done) by debbugs.gnu.org; 8 Nov 2019 03:59:24 +0000 Original-Received: from localhost ([127.0.0.1]:44359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSvQh-000636-Sj for submit@debbugs.gnu.org; Thu, 07 Nov 2019 22:59:24 -0500 Original-Received: from host.gofardesign.uk ([208.79.239.190]:40071) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSvQg-00062t-CU for 24012-done@debbugs.gnu.org; Thu, 07 Nov 2019 22:59:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qjUtv1XArZoNZRvdvXs7rmbeYY7rVO1l7KCnz3zly6c=; b=EAfzxazQB9AjHKzVeuV/mu9f5u qtzfYhfyVsBRZCMbEJVc1fZduJP/G5ldFcn8XZwxKa/s3eIWj/xTv84stAUcHGoWgf4+/KaLkPjfB VKVqTRO1N3U/AR4sRZcqgBrNOqLMeJV9uhB6jCfzT9LILmrnjC6vX2qanOIqpVpCx5TY=; Original-Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:52240 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iSvQa-0007oE-6n; Thu, 07 Nov 2019 21:59:16 -0600 In-Reply-To: (Stefan Kangas's message of "Sun, 29 Sep 2019 07:15:22 +0200") X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171156 Archived-At: Stefan Kangas writes: > Dmitry Gutov writes: > >> On 7/17/16 2:04 PM, Leo Liu wrote: >>> 1. Use the attached file as an example, open it in emacs in ruby-mode >>> 2. Move point to end of buffer and eval (forward-comment (- (point))) >>> The last step takes about 0.25 seconds on my MacBook 3 GHz Intel Core >>> i7. If you double the lines of comments, the time increase by 4 folds. >> >> FWIW, it looks fixed in the master branch now. >> >> Probably by 14b95587520959c5b54356547a0a69932a9bb480, so no idea what exactly >> was causing it. > > Indeed. I only see O(n) on current master -- that is, if I use the > source code from the original report, and double the amount of lines > by C-x h M-w C-y, the time to evaluate this expression in a buffer > only doubles: > > (progn (end-of-buffer) (forward-comment (- (point)))) > > Leo, are you still seeing this issue? If I don't hear back within a > couple of weeks, I'll just assume that this has been fixed and close > this bug. More information was requested, but none was given within 5 weeks, so I'm closing this bug. If this is still an issue, please reopen the bug report. Best regards, Stefan Kangas