From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#38317: Buffer-local variables don't work as history for read-from-minibuffer Date: Wed, 27 Nov 2019 23:19:11 +0200 Organization: LINKOV.NET Message-ID: <87y2w18bi8.fsf@mail.linkov.net> References: <87eey0lxxm.fsf@gmail.com> <87v9rcqbls.fsf@gnus.org> <5a0c68d0-4d25-bf8d-fbe8-f106b0f92210@gmx.at> <875zjareo1.fsf@gnus.org> <874kyu72kl.fsf@gmail.com> <87wobq5gs0.fsf@gmail.com> <87o8wyl2wa.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="249191"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 38317@debbugs.gnu.org To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 27 22:56:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ia5IM-0012dU-Nj for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Nov 2019 22:56:23 +0100 Original-Received: from localhost ([::1]:43534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ia5IL-00005S-86 for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Nov 2019 16:56:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50369) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ia5I6-0008VC-Ie for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 16:56:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ia5I2-00015x-Kg for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 16:56:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50321) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ia5I2-00015b-Fg for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 16:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ia5I2-00087R-DS for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 16:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Nov 2019 21:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38317 X-GNU-PR-Package: emacs Original-Received: via spool by 38317-submit@debbugs.gnu.org id=B38317.157489175431169 (code B ref 38317); Wed, 27 Nov 2019 21:56:02 +0000 Original-Received: (at 38317) by debbugs.gnu.org; 27 Nov 2019 21:55:54 +0000 Original-Received: from localhost ([127.0.0.1]:56289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ia5Ht-00086f-Q8 for submit@debbugs.gnu.org; Wed, 27 Nov 2019 16:55:53 -0500 Original-Received: from camel.birch.relay.mailchannels.net ([23.83.209.29]:17517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ia5Hr-00086W-8N for 38317@debbugs.gnu.org; Wed, 27 Nov 2019 16:55:51 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id EC97A2143C; Wed, 27 Nov 2019 21:55:49 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a94.g.dreamhost.com (100-96-4-107.trex.outbound.svc.cluster.local [100.96.4.107]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 53C2321DA4; Wed, 27 Nov 2019 21:55:49 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a94.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 27 Nov 2019 21:55:49 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Power-Abaft: 6b504b927111e675_1574891749596_3313524259 X-MC-Loop-Signature: 1574891749596:2022281800 X-MC-Ingress-Time: 1574891749595 Original-Received: from pdx1-sub0-mail-a94.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a94.g.dreamhost.com (Postfix) with ESMTP id 114A69C45A; Wed, 27 Nov 2019 13:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=o3ynUs7+sjcl826y+NdeeaPPdag=; b= ZIbaVLPxseM56YqHb+ORD3utyuxO8TV+abhwQaJ5zpe1xPrXJJ/nufHZzip9WLI9 tvJ74EKkcDcPGFePievq18oCDgRywl+frliMCBZiIetk4qEHgOw7pDT1UYX1Y+J4 QXOJ7YyLt6BoIlZkM44O36/3PVgIuCqNffWiK0sJnKw= Original-Received: from mail.jurta.org (m91-129-96-42.cust.tele2.ee [91.129.96.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a94.g.dreamhost.com (Postfix) with ESMTPSA id D758F9C453; Wed, 27 Nov 2019 13:55:44 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a94 In-Reply-To: <87o8wyl2wa.fsf@gmail.com> (Federico Tedin's message of "Tue, 26 Nov 2019 22:54:29 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172559 Archived-At: > I'm now attaching a final version of my patch. > > I've tested the following commands with it, using `read-from-minibuffer' > with a buffer-local HIST: > > - previous-history-element (M-p) > - next-history-element (M-n) > - previous-matching-history-element (M-r) > - next-matching-history-element (M-s) > - isearch-forward (C-s) > - isearch-backward (C-r) Thanks, only one question about the function name: > +(defun minibuffer-history-values () > + "Return the minibuffer input history values. Why "values" in the plural form? This looks like a multivalued function. It would be more clear with a singular "value".