From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#40532: 28.0.50; eww/shr: Anchor link does not work Date: Sat, 25 Apr 2020 21:28:37 +0100 Message-ID: <87y2qjxqbu.fsf@tcd.ie> References: <87sghckn7p.fsf@milkypond.org> <87o8rk597f.fsf@milkypond.org> <87blnj92dy.fsf@tcd.ie> <87imhr65p2.fsf@tcd.ie> <878sijpqr0.fsf@milkypond.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="85331"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 40532@debbugs.gnu.org To: Arnaud Fontaine Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 25 22:29:25 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jSRQT-000M2r-CN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Apr 2020 22:29:25 +0200 Original-Received: from localhost ([::1]:47056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSRQS-00072f-CQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Apr 2020 16:29:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44750) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSRQL-00071s-BH for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 16:29:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSRQ6-0001nZ-0y for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 16:29:17 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48891) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSRQ5-0001nF-LX for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 16:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSRQ5-0006Mj-IV for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 16:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Apr 2020 20:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40532 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40532-submit@debbugs.gnu.org id=B40532.158784652724450 (code B ref 40532); Sat, 25 Apr 2020 20:29:01 +0000 Original-Received: (at 40532) by debbugs.gnu.org; 25 Apr 2020 20:28:47 +0000 Original-Received: from localhost ([127.0.0.1]:60437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSRPr-0006MI-Ae for submit@debbugs.gnu.org; Sat, 25 Apr 2020 16:28:47 -0400 Original-Received: from mail-wm1-f68.google.com ([209.85.128.68]:36151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSRPp-0006M4-HY for 40532@debbugs.gnu.org; Sat, 25 Apr 2020 16:28:45 -0400 Original-Received: by mail-wm1-f68.google.com with SMTP id u127so15805083wmg.1 for <40532@debbugs.gnu.org>; Sat, 25 Apr 2020 13:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5M47oOuHpy78ZEm82KQlYFTrWfSktJI6YIfpnq/un8w=; b=IdooMjwzuzHfQPjp1nEK4m0z7a0MaHzCUtnkn9qrFA8eOtScC5/FYJQQwlpM/9bAVh 1W43wrCJlttUdWhIq2bo+YN1EgoLP78cnOzz0zst2KCWxaIdtDzvJlaz+djtlcnBUQ2H DlnofXWsEL9g5xhn44Xq2xekbCjSMT6KJp5KapmTY5Xp56XRiAWTYyFl17A4FT1iyuOD YRTMHWLplEiTmQHzw/yeAAetLJKGtR1kXld5WmPICX6Q8pBPu9Zp4WlqcAd28uOt7bzL YCy4H6cVWuBBYJtLr10PJraYx7NS5lKdozid70o0NM644OxEE6GzrsrrmyF5hTcSPmCg 7TRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5M47oOuHpy78ZEm82KQlYFTrWfSktJI6YIfpnq/un8w=; b=LqU+hMlNtyTuxzTweoDs7JHQn7QRGJC8CQLrMtjgvXhE8E+Diumyp+W2LwoNpzBTLY 3pq18OsJaKbA/+aeNkrafPCk9JwkAVtB0j0rjRgwspvstkzduAIY4TNiOKQSi+rlD6+e 6R/ulmVhGeayqWtUsBtzx4cgClS0x6uCwvLRppP5K2MkXyZIsthNiLB0fipRpL9Jn91Q WDe1O5+3yBQAQv2cBEwxm3p+PUjFXvb2CjnZBpiaJ+XufFGY7RTm1YjZV87ElXLkSqBU qfOjSmfnVlYQSCIR3twndwIDvN0tYa0/v+s9jy9MgrqcWKxlaZAlPCPI7im4ITSwyNhH /75g== X-Gm-Message-State: AGi0Pua3UGP9iEHxGuC8bLlKhWwLoILKDVoZrLCF7nhmtmiJ+qshnIk6 1FPzRw2L7XCnTYeXr/DVG3LhVQ== X-Google-Smtp-Source: APiQypJwj7DSaKOl5qd+cLW+bdS90uBHzgF7QSZOWHJ8bbkuj1apPyAAB2L2QBJpA9gzn51FHWFSbA== X-Received: by 2002:a05:600c:2214:: with SMTP id z20mr18933164wml.189.1587846519546; Sat, 25 Apr 2020 13:28:39 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id k3sm15853038wru.90.2020.04.25.13.28.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2020 13:28:38 -0700 (PDT) In-Reply-To: <878sijpqr0.fsf@milkypond.org> (Arnaud Fontaine's message of "Sat, 25 Apr 2020 23:46:43 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179032 Archived-At: Arnaud Fontaine writes: >> Here's an even better fix for the regression IMO: >> >> From 541a85fd17193a67883a36876fb982710abe4f7d Mon Sep 17 00:00:00 2001 >> From: "Basil L. Contovounesios" >> Date: Wed, 22 Apr 2020 11:42:17 +0100 >> Subject: [PATCH] Fix eww-follow-link on URLs with #target > > While wikipedia works fine with your patch, I have noticed that the > following does not work though: > 0. emacs -Q > 1. M-x eww RET https://distrowatch.com/weekly.php?issue=20200413 RET > 2. C-s HoleOS RET (place point on ToC entry "New distributions: HoleOS") > 3. RET (eww-follow link) > > This goes to the top of the page. Indeed, I've noticed this issue before, but it's a separate issue to the regression we've been discussing so far. Here's a more easily reproducible recipe if you build Emacs from its source repository (if I visit the given distrowatch site using Emacs 25 or 26 for some reason HoleOS is not mentioned): 0. ./src/emacs -Q 1. M-x eww-open-file RET admin/unidata/copyright.html RET 2. C-s misc RET RET This jumps to point-min rather than the Miscellaneous heading, and is reproducible since at least Emacs 25. The problem is with relative targets: for some reason shr-target-id is not set appropriately when shr is rendering the page, so no shr-target-id text property gets set, and eww can't subsequently find anywhere to jump to. Perhaps shr should unconditionally (without requiring shr-target-id to be bound) mark all possible targets with text properties during rendering. I'll see if I can get this or any other way working today or tomorrow, but either way this won't be fixed in Emacs 27. Thanks, -- Basil