From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest Date: Mon, 18 May 2020 01:03:16 +0300 Organization: LINKOV.NET Message-ID: <87y2pqi5i3.fsf@mail.linkov.net> References: <87ftbzva1f.fsf@rub.de> <877dxb4hzh.fsf@mail.linkov.net> <878shrey7h.fsf@gmx.net> <874ksfexjr.fsf@gmx.net> <87wo5aemyc.fsf@gmx.net> <87sgfyel87.fsf@gmx.net> <3F5C83BD-F7CE-4D22-96E0-E96C263A5B75@gnu.org> <87o8qmehvt.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="35882"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41338@debbugs.gnu.org, konrad.podczeck@univie.ac.at To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 18 00:40:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jaRx4-0009BZ-F6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 May 2020 00:40:10 +0200 Original-Received: from localhost ([::1]:44574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaRx2-0000Uy-7h for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 May 2020 18:40:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaRZk-0007QX-Q3 for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 18:16:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jaRZh-0001xd-QI for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 18:16:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jaRZh-000606-MQ for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 18:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 May 2020 22:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41338 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: martin rudalics , Eli Zaretskii , 41338@debbugs.gnu.org, bug-gnu-emacs@gnu.org, Konrad Podczeck Original-Received: via spool by submit@debbugs.gnu.org id=B.158975370922998 (code B ref -1); Sun, 17 May 2020 22:16:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 May 2020 22:15:09 +0000 Original-Received: from localhost ([127.0.0.1]:45011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaRYq-0005ys-P7 for submit@debbugs.gnu.org; Sun, 17 May 2020 18:15:09 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:52874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaRYp-0005yj-An for submit@debbugs.gnu.org; Sun, 17 May 2020 18:15:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaRYj-0007AB-2B for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 18:15:06 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:44079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaRYe-00016R-8P; Sun, 17 May 2020 18:14:57 -0400 X-Originating-IP: 91.129.104.245 Original-Received: from mail.gandi.net (m91-129-104-245.cust.tele2.ee [91.129.104.245]) (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 8189E1BF205; Sun, 17 May 2020 22:14:35 +0000 (UTC) In-Reply-To: <87o8qmehvt.fsf@gmx.net> (Stephen Berman's message of "Sun, 17 May 2020 16:49:26 +0200") Received-SPF: pass client-ip=217.70.183.201; envelope-from=juri@linkov.net; helo=relay8-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/17 16:22:17 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180521 Archived-At: > I found Juri's post confusing, probably because I know next to nothing > about frame events. He quotes this comment in isearch-mode-map: > > ;; Pass frame events transparently so they won't exit the search. Actually this comment is confusing. It makes no sense to me. What makes more sense is that frame events should exit the search, because such frame events as ‘switch-frame’ and ‘delete-frame’ change the current buffer (‘switch-frame’ changes the current buffer to the buffer on the switched frame, and ‘delete-frame’ changes the current buffer to the buffer on the remaining frame). There are precautions in isearch.el that take care to exit isearch when the current buffer changes because many things break in this case. One of things that breaks is that reported in this bug report where isearch-mode remembers tool-bar-map that was active in the current buffer before starting isearch, then frame deletion by clicking on the 'X' (close frame button) in the frame's title bar changes the current buffer to the buffer of the remaining frame while isearch is still active, then isearch-done called in another buffer restores tool-bar-map in wrong buffer. > but then says "and indeed the ‘switch-frame’ event is fired when the > frame is switched during isearch, and it exits isearch", which seems to > contradict the comment. Yes, this contradicts the comment because the comment makes no sense. > But in any case, according to my tests, switch > the frame does indeed exit Isearch, whether via `C-x 5 o' or the > toolkits `Alt-TAB'. In my tests it exits isearch as well, and this is the right thing to do. > Juri added: "But I don't know why the > ‘delete-frame’ event is not fired on frame deletion." But my tests > indicate that, unlike when switching the frame, when deleting the frame, > Isearch is exited only when the delete frame event comes from Emacs, not > from the toolkit. And my tests show the same: 'C-x 5 0' exits isearch, but clicking on the close frame button doesn't exit isearch - that's the problem.