From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41821: 28.0.50; read-directory-name in vc commands should provide defaults from projects Date: Sun, 21 Jun 2020 02:51:56 +0300 Organization: LINKOV.NET Message-ID: <87y2oh8fdv.fsf@mail.linkov.net> References: <87r1ulxk48.fsf@mail.linkov.net> <7164426e-8c37-8839-64da-563cfa829b53@yandex.ru> <87mu50j5cu.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="32207"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41821@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 21 02:00:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jmnPE-0008J8-8b for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jun 2020 02:00:16 +0200 Original-Received: from localhost ([::1]:39302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmnPD-000673-8K for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Jun 2020 20:00:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmnP1-00064z-Pt for bug-gnu-emacs@gnu.org; Sat, 20 Jun 2020 20:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jmnP1-0001Ea-Cr for bug-gnu-emacs@gnu.org; Sat, 20 Jun 2020 20:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jmnP1-0002Jq-BA for bug-gnu-emacs@gnu.org; Sat, 20 Jun 2020 20:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jun 2020 00:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41821 X-GNU-PR-Package: emacs Original-Received: via spool by 41821-submit@debbugs.gnu.org id=B41821.15926975428781 (code B ref 41821); Sun, 21 Jun 2020 00:00:03 +0000 Original-Received: (at 41821) by debbugs.gnu.org; 20 Jun 2020 23:59:02 +0000 Original-Received: from localhost ([127.0.0.1]:58946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmnO2-0002HP-67 for submit@debbugs.gnu.org; Sat, 20 Jun 2020 19:59:02 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:42605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmnO0-0002Ga-Gy for 41821@debbugs.gnu.org; Sat, 20 Jun 2020 19:59:00 -0400 Original-Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 5ACC0100004; Sat, 20 Jun 2020 23:58:54 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Sat, 20 Jun 2020 04:35:40 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182222 Archived-At: >> Maybe something like: > > Not too bad. > > Though I'd rather not extend the public contract of project.el with > a function that special-cases VC projects. > > So maybe something like this instead: > > +;; Or use project-try-vc after all. But this should be faster in the > +;; event when there actually are non-VC based projects in the list. > +(defun vc--known-vc-roots () > + (require 'project) > + (defvar project--list) > + (project--ensure-read-project-list) Calling internal project.el functions from vc.el? Really? > Personally, though, when I want behavior like this, I would probably just > type 'C-x p v'. 'C-x p v' is not a replacement for 'C-x v L'. > The directory name reading with completion performed by > project-prompt-project-dir is more quick and handy (though I'll confess > to using Ivy as the completion UI for this and one other function; vertical > completion fits these long string values best). 'M-n' works fine without Ivy to select a recent project dir. > It also puts the selected project on the top of the list, which > vc--known-vc-roots (or your function) don't do. I don't understand what is the selected project. The current project? Then neither 'C-x p v', nor 'C-x v L' should ask for a project directory when called from default-directory of the current project.