From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el Date: Sun, 21 Jun 2020 18:55:34 +0100 Message-ID: <87y2og8fs9.fsf@tcd.ie> References: <87sgeo7ixe.fsf@thornhill.no> <87h7v4ip1g.fsf@tcd.ie> <87lfkg48lr.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="50578"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41977@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 21 19:56:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jn4CQ-000D29-Tj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jun 2020 19:56:11 +0200 Original-Received: from localhost ([::1]:46534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jn4CP-0002GT-Er for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jun 2020 13:56:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jn4CI-0002G9-Az for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 13:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49331) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jn4CI-0003W5-2A for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 13:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jn4CI-0002kK-0x for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 13:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jun 2020 17:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41977-submit@debbugs.gnu.org id=B41977.159276214510528 (code B ref 41977); Sun, 21 Jun 2020 17:56:01 +0000 Original-Received: (at 41977) by debbugs.gnu.org; 21 Jun 2020 17:55:45 +0000 Original-Received: from localhost ([127.0.0.1]:60877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn4C0-0002jk-SV for submit@debbugs.gnu.org; Sun, 21 Jun 2020 13:55:45 -0400 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:36981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn4By-0002jU-6X for 41977@debbugs.gnu.org; Sun, 21 Jun 2020 13:55:43 -0400 Original-Received: by mail-wm1-f44.google.com with SMTP id y20so13636364wmi.2 for <41977@debbugs.gnu.org>; Sun, 21 Jun 2020 10:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=IzL1FojvVaTry0LpTScQBaIUf8PV+Of0nxMe09n4SFU=; b=0KrWMDsDTnI1t+O2/5dpZt/hppeeQZ+k28Jr42k0KmT57olAzf6B/xDD81uusgC8so mUmratte3vG8UDV4aIGrOMt7ZbAlqEfbpGfqjiUF6Ka4KDIrQJ/RrFGW08JgDkc3LOeL GGpC73PrS/FvgfYbyHm9AXMYfs6U/OL/K2BRhCQ783i2tc3tPLx8Wvuz0jfU/GMKKg4X BgulLx9yVYNMJOcRTJGF2+8Vpt9bA7ZEgztTRn+F7TkcE0RA81W2y4md6c+0vp1GvcRo YoEU4K0Jdy9N5jn3uakbbpk0LsvuEKFY/ISz8tP+cJCX5/5z9L7WPw5kTbXF6G2pIqte LHtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=IzL1FojvVaTry0LpTScQBaIUf8PV+Of0nxMe09n4SFU=; b=XEAC4a7K8ak/pWQQ8Qn8YX0Ye2cXs9D8/8GhLNdnIHfkjwV2iXji0uvUzJt4ceuUnA cOv8DxUuq0swd7LIgTv7/U7gqkmiD+6Hbh4SXKsGZSWpXtJqTKnpQHvuZnuwBJy6f53R v0lFW6KmMSmm4bL0VedbpBWdecqXlxJZXkQDLWVrqb49udRhi7pxpgye98j8SUup2ilb IYcxSN6wNtLTb3ScY/QdFkdmjl3ZKhhRU937GuOen5SSWrxspWR+z6rZUIItzm6CAJpA 2vsAJJwK0UTcJotVAOGEK8fXY2FHgVczKEJI4Nl5w9yHNmIaaxL20F0gygpMszdFyhSw 1ZAA== X-Gm-Message-State: AOAM532W2xrZMpW0DSVO1kQwpVc8ELkz34LXZpEvaHxw18EkUboGh7SF 2V/j5w7l+MjQ7ldJVL/D7G3yJA== X-Google-Smtp-Source: ABdhPJy3zgsMa/0RYcgY2ZowZVYmY09PNv4HFrOkI94BIKvrdwS7W1IvjJuEX5KAeSbuLEv8z4Sf+Q== X-Received: by 2002:a7b:ce14:: with SMTP id m20mr5821421wmc.129.1592762136245; Sun, 21 Jun 2020 10:55:36 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id b19sm20740238wmj.0.2020.06.21.10.55.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 10:55:35 -0700 (PDT) In-Reply-To: <87lfkg48lr.fsf@thornhill.no> (Theodor Thornhill's message of "Sun, 21 Jun 2020 17:44:24 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182253 Archived-At: Theodor Thornhill writes: > "Basil L. Contovounesios" writes: > >> Since eshell-buffer-name is a variable, eval-when-compile is not the >> right thing to do here. Instead, there should be a >> (defvar eshell-buffer-name) inside project-eshell declaring the symbol >> as special. Right? > > You are absolutely correct, and TIL - thanks :) > > Below is another patch doing this. Works fine in emacs -Q Thanks, LGTM. -- Basil