unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Theodor Thornhill <theo@thornhill.no>
Cc: 41977@debbugs.gnu.org
Subject: bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el
Date: Sun, 21 Jun 2020 18:55:34 +0100	[thread overview]
Message-ID: <87y2og8fs9.fsf@tcd.ie> (raw)
In-Reply-To: <87lfkg48lr.fsf@thornhill.no> (Theodor Thornhill's message of "Sun, 21 Jun 2020 17:44:24 +0000")

Theodor Thornhill <theo@thornhill.no> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> Since eshell-buffer-name is a variable, eval-when-compile is not the
>> right thing to do here.  Instead, there should be a
>> (defvar eshell-buffer-name) inside project-eshell declaring the symbol
>> as special.  Right?
>
> You are absolutely correct, and TIL - thanks :)
>
> Below is another patch doing this. Works fine in emacs -Q

Thanks, LGTM.

-- 
Basil





  reply	other threads:[~2020-06-21 17:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-21 11:33 bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el Theodor Thornhill
2020-06-21 12:25 ` Basil L. Contovounesios
2020-06-21 17:44   ` Theodor Thornhill
2020-06-21 17:55     ` Basil L. Contovounesios [this message]
2020-06-21 22:52       ` Dmitry Gutov
2020-06-21 23:02         ` Basil L. Contovounesios
2020-06-21 23:07           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2og8fs9.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=41977@debbugs.gnu.org \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).