From: "Philip K." <philip@warpmail.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 42386@debbugs.gnu.org
Subject: bug#42386: Acknowledgement ([PATCH] Handle symbols in project-kill-buffers-ignores)
Date: Fri, 17 Jul 2020 10:16:59 +0200 [thread overview]
Message-ID: <87y2nitv2c.fsf@warpmail.net> (raw)
In-Reply-To: <83d04uk5nf.fsf@gnu.org> (message from Eli Zaretskii on Fri, 17 Jul 2020 09:38:28 +0300)
Eli Zaretskii <eliz@gnu.org> writes:
>> + (lambda (c)
>> + (cond ((stringp c)
>> + (string-match-p c (buffer-name buf)))
>> + ((and (not (memq c project-kill-buffers-ignores))
>> + (functionp c))
>
> Once again, I don't think I understand why you need the memq part.
The issue is that a major mode symbol is interpreted as a function, and
that triggers an error. So if I want to keep shell-mode buffers, and I'm
checking an emacs-lisp-mode buffer, the major mode isn't part of
project-kill-buffers-ignores (-> first memq), so the seq-some is
evaluated, and because shell-mode is a function, the code would try to
evaluate it as a predicate, but that fails.
I realise just now how stupid the memq is, because instead of stopping
major-mode symbols from being evaluated, I just stop everything, as
every member of the list is tautologically part of the list.
I don't see any way around this, except for trying to analyse the
symbols string representation or checking the arity if the
function. Neither seem like a particularly clean approach.
--
Philip K.
next prev parent reply other threads:[~2020-07-17 8:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 8:15 bug#42386: [PATCH] Handle symbols in project-kill-buffers-ignores Philip K.
[not found] ` <handler.42386.B.159488736413990.ack@debbugs.gnu.org>
2020-07-16 8:47 ` bug#42386: Acknowledgement ([PATCH] Handle symbols in project-kill-buffers-ignores) Philip K.
2020-07-16 15:14 ` Eli Zaretskii
2020-07-16 18:08 ` Philip K.
2020-07-16 18:16 ` Philip K.
2020-07-16 19:35 ` Eli Zaretskii
2020-07-16 22:22 ` Philip K.
2020-07-17 6:38 ` Eli Zaretskii
2020-07-17 8:16 ` Philip K. [this message]
2020-07-17 10:49 ` Eli Zaretskii
2020-07-17 11:17 ` Philip K.
2020-07-17 11:26 ` Eli Zaretskii
2020-07-17 15:30 ` Philip K.
2020-07-17 15:43 ` Dmitry Gutov
2020-07-17 17:16 ` Philip K.
2020-07-17 22:21 ` Dmitry Gutov
2020-07-18 12:48 ` Philip K.
2020-07-19 23:10 ` Dmitry Gutov
2020-07-20 12:07 ` Philip K.
2020-07-20 13:39 ` Dmitry Gutov
2020-07-21 9:11 ` Philip K.
2020-07-21 14:27 ` Eli Zaretskii
2020-07-21 18:35 ` Philip K.
2020-07-21 18:57 ` Eli Zaretskii
2020-07-21 20:47 ` Dmitry Gutov
2020-07-21 18:45 ` Dmitry Gutov
2020-07-21 18:51 ` Philip K.
2020-07-27 16:26 ` Dmitry Gutov
2020-07-27 18:33 ` Philip K.
2020-07-28 22:33 ` Dmitry Gutov
2020-07-16 18:41 ` Dmitry Gutov
2020-07-16 22:46 ` Juri Linkov
2020-07-17 0:23 ` Dmitry Gutov
2020-07-16 13:43 ` bug#42386: [PATCH] Handle symbols in project-kill-buffers-ignores Dmitry Gutov
2020-07-16 18:00 ` Philip K.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2nitv2c.fsf@warpmail.net \
--to=philip@warpmail.net \
--cc=42386@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).