From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#32034: 26.1; [PACTH] better xref-location-marker for imperfect file locations Date: Mon, 10 Aug 2020 21:42:18 +0100 Message-ID: <87y2mm44id.fsf@gmail.com> References: <87y3etsqb7.fsf@gmail.com> <83601xlmno.fsf@gnu.org> <87muv9sll6.fsf@gmail.com> <83po05k5rx.fsf@gnu.org> <87bmbpskl8.fsf@gmail.com> <83muv9k38v.fsf@gnu.org> <87o9fpfuhe.fsf@gmail.com> <83lgatk0ku.fsf@gnu.org> <87zh724pya.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8577"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 32034@debbugs.gnu.org, Helmut Eller , Dmitry Gutov To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 10 22:43:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5EdS-00028y-Nj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 22:43:10 +0200 Original-Received: from localhost ([::1]:42486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5EdR-0005SN-6U for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 16:43:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5EdK-0005SC-C0 for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 16:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54276) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5EdK-0002GV-2j for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 16:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5EdJ-0002EM-VU for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 16:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Aug 2020 20:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32034 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32034-submit@debbugs.gnu.org id=B32034.15970921508503 (code B ref 32034); Mon, 10 Aug 2020 20:43:01 +0000 Original-Received: (at 32034) by debbugs.gnu.org; 10 Aug 2020 20:42:30 +0000 Original-Received: from localhost ([127.0.0.1]:37589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5Eco-0002D3-CM for submit@debbugs.gnu.org; Mon, 10 Aug 2020 16:42:30 -0400 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:42454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5Ecl-0002Ci-Du for 32034@debbugs.gnu.org; Mon, 10 Aug 2020 16:42:29 -0400 Original-Received: by mail-wr1-f46.google.com with SMTP id r4so9416792wrx.9 for <32034@debbugs.gnu.org>; Mon, 10 Aug 2020 13:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=HxjkXTmUH35mYtAiV1SsVEmuyMTzSSOulqOSfRzULvQ=; b=OX+Cb/h/W3Xr1TWllENwQkMWSGMr+SZ5lEcDXljleTx2xSUTETWFAP12vfiGNhV8cH MH5LDiW9W7KoPSEu1Dn/Sw+QqoRt67kSPqm6VL0XMuPsLVRd9UHtTLmKPS5SUetFtsDq OMJnPla0FEE0D+DLUCfhvY3FbJi40hR9OQqaWWNDSKtr7Im8zzBcMRXou9eXxVSXrw7n D02wJW9tS3VaXtq4O6q0G5GXRnX9TMFbAqZkKsPtIFweAwwv+uALTLhbvZp0oqz6TrYs 2M9Pqeja7quvIMSdnx6gWqYvSBxOFny52SouLx8k77AnYWy7+DKww4YKBcnSayqtQyE9 9nbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=HxjkXTmUH35mYtAiV1SsVEmuyMTzSSOulqOSfRzULvQ=; b=t4ADDnwsnbCfinuQVZ8wNVZWk0+g7Hd+71fz/AAOPc/cBhiow6xNpzuPy2EpEyHIwE GYFWnRyAZ1kS1JS8HauPt/pmUzjjEzy7SGFym2G/KER9Uh6tRRkJlRfzYjYGq/Gm3xuy tcJmzJkUDQtyPoVblbWxRam3fzPHr01TjymsM6Q0RH+KTnaaR7z1iCBYgsrQJYRXW7/0 rN6lBQmVjcRRBbn82koCE5CuMVEwNPR2mljEj26VQtOkvUAc96rqvVI63REtrJw9bdpl wZOFb9194Qcqa5VQofM0orralzlz4RRGPPTVejaQ6ofMkxOnsob4hXzqBz9GAc9igFwd 5kPw== X-Gm-Message-State: AOAM5321/TWH2t9E6ER6y5Ei64UKfekiy58krRLO6Zv6M5pHMXIswOUZ d6sFskoCKCF9ZyUzYCsN8ek= X-Google-Smtp-Source: ABdhPJxCt4PObpwRDz60Aa6qrF5GHTDQd4DRP3Vbp8irf8Q4CDbZYBXhj3ot+DfYc2uifPLtruyALw== X-Received: by 2002:adf:aa9e:: with SMTP id h30mr25170682wrc.377.1597092141314; Mon, 10 Aug 2020 13:42:21 -0700 (PDT) Original-Received: from krug (89-180-144-39.net.novis.pt. [89.180.144.39]) by smtp.gmail.com with ESMTPSA id b203sm1244415wmc.22.2020.08.10.13.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2020 13:42:20 -0700 (PDT) In-Reply-To: (Dmitry Gutov's message of "Mon, 10 Aug 2020 21:53:32 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184582 Archived-At: On 10.08.2020 15:59, Lars Ingebrigtsen wrote: Hi Lars, thanks for pinging me. > This was over two years ago, and there was some followup discussion > between Dmitry and Jo=C3=A3o, but I think the consensus here was that the > patches fixes a real problem, ans should probably be applied? As far as > I can see, that never happened. I read the discussion. As far as I know the problem reported originally persists. A small patch does exist, has two parts: 1 and 2. Part 2 apparently had some real problem that I don't understand anymore, not sure if it still applies. I seem to have said it was easy to fix, though it wouldn't much matter if we could devise a much better fix, later known as number 3. The rest of the discussion consists of hypothetical problems (about seemingly hypothetical backends), leveled against that nr. 3 patch, which seems never to have seen the light of day: I made the mistake of tagging along with the hypotheticals and then probably ran out of time. If I recall correctly, that better patch, were it to exist, would do what is done by SLIME, the thing xref.el was based on when it was originally written by Helmut Eller. SLIME has done it for a very long time and quite successfully: the objects that represent cross-references contain optional extra bits of information -- hints -- which help, heuristically, when locating the thing being looked for. My fork of SLIME, SLY, hasn't yet switched to xref.el partly because of xref.el's limitations in this regard. Eglot would also benefit (the original report concerns Eglot). Alas, that nr 3 patch is vapourware. Maybe I or someone will make it in the future, and then we can talk about real stuff. I think we should look to SLIME (and maybe Helmut?) for inspiration in fixing this, but I don't have time to do this right now. The original thread where xref.el is originally discussed is relevant here, for posterity: https://lists.gnu.org/archive/html/emacs-devel/2014-12/msg01253.html Jo=C3=A3o