From: Lars Ingebrigtsen <larsi@gnus.org>
To: Ryan <rct@thompsonclan.org>
Cc: 27158@debbugs.gnu.org
Subject: bug#27158: 25.2; Eliminating old usage of completing-read from built-in files
Date: Mon, 24 Aug 2020 16:58:33 +0200 [thread overview]
Message-ID: <87y2m4850m.fsf@gnus.org> (raw)
In-Reply-To: <24f4a025-ad7b-06e5-10ee-f122bef32402@thompsonclan.org> (Ryan's message of "Wed, 31 May 2017 00:41:57 -0400")
Ryan <rct@thompsonclan.org> writes:
> completing-read-default still supports a behavior that is, as far as I
> know, a legacy feature that is kept only for backward compatibility with
> code that was written before the default argument was added: if the
> input is empty and the user presses RET, it will return the empty
> string, even if require-match is non-nil and the empty string is not in
> the collection.
[...]
> While this behavior can
> probably not be changed without breaking backward compatibility, we can
> at least eliminate every use of the feature in the elisp files included
> with Emacs. The patch below does exactly that for all the cases that I
> am aware of.
[...]
> - (completing-read "Keyword, C-h: " v1 nil t))
> + (completing-read "Keyword, C-h: " v1 nil t nil nil ""))
If we're not going to change the behaviour, I don't really see any
advantage to changing the in-tree callers, so I'm closing this bug
report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-08-24 14:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 4:41 bug#27158: 25.2; Eliminating old usage of completing-read from built-in files Ryan
2017-05-31 5:52 ` Drew Adams
2017-05-31 11:45 ` Ryan Thompson
2017-05-31 14:51 ` Drew Adams
2017-05-31 12:23 ` Dmitry Gutov
2017-05-31 14:51 ` Drew Adams
2017-05-31 14:59 ` Dmitry Gutov
2017-05-31 15:19 ` Drew Adams
2017-05-31 15:44 ` Ryan Thompson
2017-05-31 22:41 ` Dmitry Gutov
2017-05-31 23:16 ` Drew Adams
2017-05-31 23:54 ` Dmitry Gutov
2017-06-01 2:23 ` Drew Adams
2017-06-01 9:27 ` Dmitry Gutov
2017-06-01 14:57 ` Drew Adams
2017-06-01 20:53 ` Dmitry Gutov
2017-06-01 21:04 ` Ryan Thompson
2017-06-05 23:01 ` Dmitry Gutov
2017-06-06 0:06 ` Ryan Thompson
2017-06-06 0:09 ` Dmitry Gutov
2017-05-31 21:20 ` Dmitry Gutov
2020-08-24 14:58 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2m4850m.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=27158@debbugs.gnu.org \
--cc=rct@thompsonclan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).