From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43242: [PATCH] Fix CSS completion bug Date: Sun, 06 Sep 2020 21:30:45 +0200 Message-ID: <87y2lmd7oa.fsf@gnus.org> References: <87mu239ih4.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28361"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43242@debbugs.gnu.org To: "Philip K." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 06 21:31:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kF0Nj-0007Gx-0m for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Sep 2020 21:31:19 +0200 Original-Received: from localhost ([::1]:35658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kF0Ni-0002PO-31 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Sep 2020 15:31:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kF0NS-0002P6-2z for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 15:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35644) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kF0NR-0001W6-QE for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 15:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kF0NR-0006ld-N9 for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 15:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Sep 2020 19:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43242-submit@debbugs.gnu.org id=B43242.159942065726000 (code B ref 43242); Sun, 06 Sep 2020 19:31:01 +0000 Original-Received: (at 43242) by debbugs.gnu.org; 6 Sep 2020 19:30:57 +0000 Original-Received: from localhost ([127.0.0.1]:47190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF0NN-0006lH-8X for submit@debbugs.gnu.org; Sun, 06 Sep 2020 15:30:57 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:47946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF0NM-0006l4-1u for 43242@debbugs.gnu.org; Sun, 06 Sep 2020 15:30:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3dybYTqspt6moPoB0DrR35RJ9vF19a6pdoW952fdLpc=; b=lTyRSoUASPNbLQU7+69aPGgCx+ gEpzY6oBgD6Nh9ag3476uDpGWb7hIkZ4kg59n7+jKpvfzPs2uOKQtWyOgdmvAX1CANMyA10TxRqjJ ahK9JnfPoi1N9uejOMNqOrrS9J8kvlXyq3+V42deqzK9XIgpXlpwGd7Lu3LVhONqtDdY=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kF0NC-0005AE-SD; Sun, 06 Sep 2020 21:30:49 +0200 X-Now-Playing: Mike Oldfield's _Tubular Bells (1)_: "Tubular Bells Part One" In-Reply-To: <87mu239ih4.fsf@posteo.net> (Philip K.'s message of "Sun, 06 Sep 2020 14:51:03 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187377 Archived-At: "Philip K." writes: > The patch below fixes this by making sure css--complete-property-value > doesn't ignore the semi-colon. [...] > + (save-match-data > + (and (looking-back "\\([[:alnum:]-]+\\):[^/][^;]*" Looks good... but is there any particular reason to save the match data here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no