From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Kangas <stefan@marxist.se>
Cc: 43792@debbugs.gnu.org
Subject: bug#43792: [PATCH] Add ert macros to get resource file names
Date: Sun, 04 Oct 2020 19:25:50 +0200 [thread overview]
Message-ID: <87y2klvr6p.fsf@gmx.de> (raw)
In-Reply-To: <CADwFkmnd-oS+y7xxuj4B5AkM1AiP3R9U_weXerfaGRgHxVHzzg@mail.gmail.com> (Stefan Kangas's message of "Sun, 4 Oct 2020 12:40:33 +0000")
Stefan Kangas <stefan@marxist.se> writes:
Hi Stefan,
> There's a lot of repetitive code to get at the resource directories for
> tests. That's obviously boring, so I'd propose something like the
> following two macros to make it easier:
>
> (ert-resource-directory)
> (ert-resource-file NAME)
>
> Please see the attached patch, the second of which uses the macros in
> our test suite. Not sure if they should be in ert.el, so I put them in
> ert-x.el for now to play it safe.
>
> Any comments?
Nice idea. Have you tested, that it also works for GNU ELPA packages?
And no, pls change the tests in GNU ELPA yet, unless they require Emacs 28.
I miss a patch for dbus-tests.el.
For Tramp, I would need to adapt your change due to backward
compatibility. But don't worry, your patch could go as it is into master before.
Best regards, Michael.
next prev parent reply other threads:[~2020-10-04 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 12:40 bug#43792: [PATCH] Add ert macros to get resource file names Stefan Kangas
2020-10-04 17:25 ` Michael Albinus [this message]
2020-10-16 9:47 ` Stefan Kangas
2020-10-05 7:30 ` Lars Ingebrigtsen
2020-10-16 9:47 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2klvr6p.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=43792@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).