From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Nicolas Graner Newsgroups: gmane.emacs.bugs Subject: bug#44247: EWW: backtab is not defined in text and textarea keymaps Date: Mon, 26 Oct 2020 23:46:55 +0100 Message-ID: <87y2jssizk.fsf@hypra-graner> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37413"; mail-complaints-to="usenet@ciao.gmane.io" To: 44247@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 27 00:29:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXBvK-0009dO-Uv for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Oct 2020 00:29:11 +0100 Original-Received: from localhost ([::1]:50336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXBvJ-0002jH-Ch for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Oct 2020 19:29:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXBvC-0002im-6a for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 19:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58687) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXBvB-0000AT-T3 for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 19:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kXBvB-0001k6-OO for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 19:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Graner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 23:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44247 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16037548866635 (code B ref -1); Mon, 26 Oct 2020 23:29:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Oct 2020 23:28:06 +0000 Original-Received: from localhost ([127.0.0.1]:42000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXBuH-0001iw-Jm for submit@debbugs.gnu.org; Mon, 26 Oct 2020 19:28:06 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:56768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXBGb-0000Y9-Nk for submit@debbugs.gnu.org; Mon, 26 Oct 2020 18:47:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXBGb-0002pW-BA for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 18:47:05 -0400 Original-Received: from smtp-out.ouvaton.coop ([51.15.229.26]:40442) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXBGY-0003Iw-Eo for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 18:47:04 -0400 Original-Received: from panel.vitry.ouvaton.coop (panel.vitry.ouvaton.coop [194.36.166.20]) by smtp-out.ouvaton.coop (Postfix) with ESMTPS id 1BBB4C005F for ; Mon, 26 Oct 2020 22:46:57 +0000 (UTC) Original-Received: from hypra-graner (37.124.67.86.rev.sfr.net [86.67.124.37]) by panel.vitry.ouvaton.coop (Postfix) with ESMTPSA id 83B93A0FAB for ; Mon, 26 Oct 2020 23:46:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=graner.name; s=default; t=1603752416; bh=468BoUUSaKqKqlPdjqpTVyI/NWkXgGl0zB/rju73yls=; l=976; h=From:To:Subject; b=kL+57tFbP8jw+61clLqTGfeR5ZE1o+tcE4PaW8WNNil6t92Wxvver4D8k/ruoi1xF ppd2m2bRiJBgb1O3M99l94Q1Hh5P3NCfmqWTo9yV16c4b8g/LvHGapGx09CgdpJNtC Gxr3H31LIQj9UQoreuOGBBJiit4vJJD2NysU1UlY= X-PPP-Message-ID: <20201026224656.11055.62260@panel.vitry.ouvaton.coop> X-PPP-Vhost: graner.name Received-SPF: pass client-ip=51.15.229.26; envelope-from=nicolas@graner.name; helo=smtp-out.ouvaton.coop X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/26 18:46:57 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 26 Oct 2020 19:28:04 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191687 Archived-At: In the main eww-mode-map, the function shr-previous-link is bound to both \M-\t and backtab (aka shift+tab). However, in the more specific eww-text-map and eww-textarea-map, that same function is only bound to \M-\t. This makes the use of backtab inconsistent. Patch to fix this in emacs 28: diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 53835bb544..ebc75e0e8a 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -1190,6 +1190,7 @@ eww-text-map (define-key map [(control e)] 'eww-end-of-text) (define-key map [?\t] 'shr-next-link) (define-key map [?\M-\t] 'shr-previous-link) + (define-key map [backtab] 'shr-previous-link) map)) (defvar eww-textarea-map @@ -1199,6 +1200,7 @@ eww-textarea-map (define-key map [(control c) (control c)] 'eww-submit) (define-key map [?\t] 'shr-next-link) (define-key map [?\M-\t] 'shr-previous-link) + (define-key map [backtab] 'shr-previous-link) map)) (defvar eww-select-map -- Nicolas