From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#19944: 25.0.50; vc-git-grep doesn't use grep-read-files correctly Date: Thu, 03 Dec 2020 12:50:14 +0100 Message-ID: <87y2ifqfbd.fsf@gnus.org> References: <889lhjmb4pg.fsf@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27512"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 19944@debbugs.gnu.org To: Rupert Swarbrick Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 03 12:51:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkn8g-0006wi-T6 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Dec 2020 12:51:10 +0100 Original-Received: from localhost ([::1]:55062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkn8f-0005m0-Vh for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Dec 2020 06:51:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkn8Y-0005kf-Ew for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 06:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55427) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kkn8X-0004Sj-T1 for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 06:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kkn8X-0004or-Re for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 06:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Dec 2020 11:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19944 X-GNU-PR-Package: emacs Original-Received: via spool by 19944-submit@debbugs.gnu.org id=B19944.160699622718470 (code B ref 19944); Thu, 03 Dec 2020 11:51:01 +0000 Original-Received: (at 19944) by debbugs.gnu.org; 3 Dec 2020 11:50:27 +0000 Original-Received: from localhost ([127.0.0.1]:38737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkn7z-0004np-3L for submit@debbugs.gnu.org; Thu, 03 Dec 2020 06:50:27 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:45490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkn7w-0004nZ-Ob for 19944@debbugs.gnu.org; Thu, 03 Dec 2020 06:50:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MH3B6ugpa7etEwjjpIplxIcvQomqMRtia05hD2+RsRA=; b=deQWondUKx1LdkUS6aD7C0JzcN rmaiUBjHtNQrUMZEDeAKblD6TfhlaYglq2Cypjd5RfcaTakw7DDVGofySFBcR8Bmvlm4ESQq1+VTF qKCFrqnVsNKMW+X8HveHVtE4JFJhcY9CjPdJt4PdAj5c/E99qwhC9f9hkb3noXjRATnw=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkn7n-00032V-Lz; Thu, 03 Dec 2020 12:50:18 +0100 X-Now-Playing: Portishead's _Only You_: "Only You (Edit)" In-Reply-To: <889lhjmb4pg.fsf@broadcom.com> (Rupert Swarbrick's message of "Wed, 25 Feb 2015 11:39:23 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194888 Archived-At: Rupert Swarbrick writes: > The vc-git-grep function uses grep-read-files to figure out the list of > files to check. This gets glued to the end of the git grep command > line. With the default value of grep-files-aliases, if the user enters > "all" for their files, grep-read-files returns the string "* .*". > > If you do the following: > > cd /path/to/my/git/repo > git grep foo -- * .* > > then you get something like: > > /path/to/my/git/repo> git grep foo -- * .* > fatal: ..: '..' is outside repository > > because .* expands to a list including "..". (This bug report unfortunately got no response at the time.) Looks like this has been fixed in more recent versions of Emacs. Trying this, I get: git --no-pager grep -n --color -i -e emacs -- \* .\[\!.\]\* ..\?\* and everything works are it should, I think. > We're also doing the wrong thing when the user gives a pattern. For > example, if I go into the top-level Emacs directory and run > > M-x vc-git-grep > > enter vc-git-grep as the string to search for and enter *g* for the > files to search, then I get: > > Grep started at Wed Feb 25 11:17:28 > > git --no-pager grep -n -e vc-git-grep -- *g* This, too -- I get: git --no-pager grep -n --color -i -e emacs -- \*g\* So I'm guessing this has been fixed, and I'm closing this bug report. If there's still a problem here, please respond to the debbugs address, and we'll reopen the bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no