From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45162: [PATCH] Fixup Re: bug#45162: 28.0.50; Messages scrambled by socks-filter Date: Thu, 07 Jan 2021 13:44:59 +0100 Message-ID: <87y2h4ykz8.fsf@gnus.org> References: <87r1nxu840.fsf@neverwas.me> <87sg8c8ic5.fsf@gnus.org> <87pn2ht4pk.fsf_-_@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10284"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45162@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 07 13:46:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxUgF-0002Nr-4Q for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jan 2021 13:46:19 +0100 Original-Received: from localhost ([::1]:39530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxUgE-0004Z4-4x for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jan 2021 07:46:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxUfy-0004Xd-P9 for bug-gnu-emacs@gnu.org; Thu, 07 Jan 2021 07:46:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35222) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kxUfy-0006pu-HN for bug-gnu-emacs@gnu.org; Thu, 07 Jan 2021 07:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kxUfy-0003Yt-F8 for bug-gnu-emacs@gnu.org; Thu, 07 Jan 2021 07:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jan 2021 12:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 45162-submit@debbugs.gnu.org id=B45162.161002351113625 (code B ref 45162); Thu, 07 Jan 2021 12:46:02 +0000 Original-Received: (at 45162) by debbugs.gnu.org; 7 Jan 2021 12:45:11 +0000 Original-Received: from localhost ([127.0.0.1]:46768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxUf8-0003Xh-MQ for submit@debbugs.gnu.org; Thu, 07 Jan 2021 07:45:10 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:37162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxUf7-0003XQ-Eh for 45162@debbugs.gnu.org; Thu, 07 Jan 2021 07:45:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+Jvvo5LYbWeZDtr4CRlMBpLG/ReQN1nVRrgj6jksxSk=; b=b2LDHAygq08zp3mbPED7y7n8Ke mwIZ93yB1fV85wjvNaS7pGFXsXYBFes2zv2pWNOUB6lu4FhHLgH9QL81zfwX43GVCaR6eM/voPoQ2 0WnooibJJpI3OqE2edlN4l9iDJe335Exky8CcSoei3Holt7ZngF4dfc7B38QTRq8Yag0=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxUey-0002aP-IZ; Thu, 07 Jan 2021 13:45:02 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEXl29L38+2nmJMZ DhIyJCdFNTdNQD9iVVIkFhqXhHvRu62Jd3H///+17V7UAAAAAWJLR0QMgbNRYwAAAAd0SU1FB+UB BwwrHEGBadoAAAGKSURBVDjL7dCxTsMwEAbgwshEX8EMpeloJDxTGzyjphnYUGMzR5BTlNGu5LkS IDGVjmbLUqm8HBcnLiwMiIWBUyJF/nL32x4cnHCh752hVy9H03NCxqtJqYfD4SDAEwLbjaYXhExq UFmAU55qcmeoWe7KxHs/Bqg7EKne3ZusTgb+aLLyZBsBO565nDfrt2QEauVjB2Zkj1wudZOWC5UX G4CqB65H1lk+s9yJWbaF975D2mxjnXTOTqmd3YzhvemBZ1tpEbhhTl6/Qf3SwhBHcePakgzf2xFU SQRcNJTiJPwoSqiaHnCKo8ZZRMeLUvcdpwFwV5JiLUFDst4D424pTQtWIfjPju53rDOl9B5CMUrx oUxBTSIIzkXerra70lCQddyuSOd5mIMAqiD9OaRIU9VFM+OUqMbxgELNlevD2WWqmz3oMndBDLVZ Pq8+AcpwKW0H5tXx5AgPEShPFcTbFQALF9INYwi66MDYDO5orDM+EzcBDgnxfkO+VpfxTf3Dn4Xj 15/Cb8M/AC5/3zTc1qi2AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTAxLTA3VDEyOjQzOjI4KzAw OjAw5tivuQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wMS0wN1QxMjo0MzoyOCswMDowMJeFFwUA AAAASUVORK5CYII= X-Now-Playing: This Mortal Coil's _1983-1991 (2): Filigree & Shadow_: "Tarantula" In-Reply-To: <87pn2ht4pk.fsf_-_@neverwas.me> (J. P.'s message of "Thu, 07 Jan 2021 02:35:19 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197476 Archived-At: "J.P." writes: > In a boneheaded oversight, I neglected to reset the "scratch" work area > after functions performing the SOCKS5 authentication subprotocol are > through with it. > > This is a one-line follow-up that hopefully corrects that. Please see > the included test, which passes after this tweak is applied. Thanks; I've now applied the fix to Emacs 28, but not the test (because the amount of code would require a copyright assignment). I forgot whether I've asked before -- would you be willing to sign such paperwork? If so, reworking that test into an ert-deftest would be nice. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no