From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core Date: Fri, 12 Mar 2021 09:59:32 +0200 Message-ID: <87y2esree3.fsf@protesilaos.com> References: <87y2f0fq8v.fsf@protesilaos.com> <87sg58tkg7.fsf@tcd.ie> <87h7lofe6b.fsf@protesilaos.com> <87mtvfpgf2.fsf@protesilaos.com> <878s6wqq40.fsf@tcd.ie> <874khk6t7d.fsf@protesilaos.com> <87mtvb1s3r.fsf@protesilaos.com> <871rcmojgc.fsf@protesilaos.com> <87lfau1tm3.fsf@tcd.ie> <87h7li9jtf.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37325"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 46964@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 12 09:00:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKciV-0009Vu-Io for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Mar 2021 09:00:15 +0100 Original-Received: from localhost ([::1]:60014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKciU-0004OD-Le for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Mar 2021 03:00:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKciI-0004O3-Bt for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 03:00:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKciI-0003sH-2q for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 03:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lKciI-0005be-0Y for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 03:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Mar 2021 08:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46964-submit@debbugs.gnu.org id=B46964.161553598421501 (code B ref 46964); Fri, 12 Mar 2021 08:00:01 +0000 Original-Received: (at 46964) by debbugs.gnu.org; 12 Mar 2021 07:59:44 +0000 Original-Received: from localhost ([127.0.0.1]:55954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKci0-0005ai-6K for submit@debbugs.gnu.org; Fri, 12 Mar 2021 02:59:44 -0500 Original-Received: from relay13.mail.gandi.net ([217.70.178.233]:20707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKchy-0005aU-G9 for 46964@debbugs.gnu.org; Fri, 12 Mar 2021 02:59:42 -0500 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay13.mail.gandi.net (Postfix) with ESMTPSA id 3D71080013; Fri, 12 Mar 2021 07:59:34 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Thu, 11 Mar 2021 17:54:00 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202145 Archived-At: On 2021-03-11, 17:54 -0500, Stefan Monnier wrote: >> At any rate, I do not know how to implement such in-place substitutes. >> Can you please point me to the relevant documentation or some previous >> case that I could study? Then I will try to produce a patch. > > Rather than point at some similar previous case, here's how I'd do it: > > Make a new commit to the the elpa.git branches `modus--theme` which > basically gut the `modus--theme.el` files, replacing them with tiny > files containing just the header (where `Package-Requires:` says > `modus-themes`) plus some shenanigans to look for the directory holding > the `modus-themes.el` file and load the matching `modus--theme.el` > from it. And maybe emit a warning just before doing that (both to > state that the package is obsolete and to warn the users about the > redirect, so they might know where to start looking in case something > goes wrong). Thank you Stefan (and Basil in the other message)! I will research those and act accordingly. Note that I do not have commit rights to elpa.git: I sent the request a few days ago. -- Protesilaos Stavrou protesilaos.com