From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#44611: Prefix arg for xref-goto-xref Date: Wed, 17 Mar 2021 19:23:58 +0200 Organization: LINKOV.NET Message-ID: <87y2elg1qx.fsf@mail.linkov.net> References: <87k0up68e4.fsf@mail.linkov.net> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87eejbbfm9.fsf@mail.linkov.net> <87sg7ponct.fsf@mail.linkov.net> <6511aade-1b6d-7a82-6848-3ccba43a794c@yandex.ru> <87bldkc028.fsf@mail.linkov.net> <871rdzam7q.fsf@mail.linkov.net> <87sg4vgef6.fsf@mail.linkov.net> <88e10bd7-87cf-dd3a-c08d-cd9a8544c2b3@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21657"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 17 18:27:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMZx1-0005WR-FD for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Mar 2021 18:27:19 +0100 Original-Received: from localhost ([::1]:53122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMZx0-0005pw-HZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Mar 2021 13:27:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMZvm-00048y-HH for bug-gnu-emacs@gnu.org; Wed, 17 Mar 2021 13:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMZvm-0002Fu-8u for bug-gnu-emacs@gnu.org; Wed, 17 Mar 2021 13:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMZvm-0004qr-5j for bug-gnu-emacs@gnu.org; Wed, 17 Mar 2021 13:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Mar 2021 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44611 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 44611-submit@debbugs.gnu.org id=B44611.161600190818581 (code B ref 44611); Wed, 17 Mar 2021 17:26:02 +0000 Original-Received: (at 44611) by debbugs.gnu.org; 17 Mar 2021 17:25:08 +0000 Original-Received: from localhost ([127.0.0.1]:43926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMZuu-0004pX-6s for submit@debbugs.gnu.org; Wed, 17 Mar 2021 13:25:08 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:36015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMZus-0004oX-EN for 44611@debbugs.gnu.org; Wed, 17 Mar 2021 13:25:06 -0400 X-Originating-IP: 91.129.107.223 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id CDD2EE000E; Wed, 17 Mar 2021 17:24:59 +0000 (UTC) In-Reply-To: <88e10bd7-87cf-dd3a-c08d-cd9a8544c2b3@yandex.ru> (Dmitry Gutov's message of "Wed, 17 Mar 2021 01:38:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202530 Archived-At: --=-=-= Content-Type: text/plain >> (defun next-error-quit-window () >> (when (and (eq current-prefix-arg 0) >> (not (eq next-error-last-buffer (current-buffer)))) >> (let ((window (get-buffer-window next-error-last-buffer))) >> (when (window-live-p window) >> (with-selected-window window >> (quit-restore-window window)))))) >> (add-hook 'next-error-hook 'next-error-quit-window) > > Since next-error-hook is a defcustom, perhaps we can/should include this > function as one of the advertised values in :type? > > Even if we keep the list nil by default. I completely forgot that we have 'next-error-found-function', so implemented it with 'next-error-hook'. I don't remember why we have both. Anyway, here is a patch with corrections from Martin: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=next-error-quit-window.patch diff --git a/lisp/simple.el b/lisp/simple.el index 94d79c2bf1..73020c2c8e 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -377,11 +377,22 @@ next-error-internal (not (eq prev next-error-last-buffer))) (message "Current locus from %s" next-error-last-buffer))))) +(defun next-error-quit-window (from-buffer to-buffer) + "Quit window of FROM-BUFFER when the prefix arg is 0. +Intended to be used in `next-error-found-function'." + (when (and (eq current-prefix-arg 0) from-buffer + (not (eq from-buffer to-buffer))) + (let ((window (get-buffer-window from-buffer))) + (when (window-live-p window) + (quit-restore-window window))))) + (defcustom next-error-found-function #'ignore "Function called when a next locus is found and displayed. Function is called with two arguments: a FROM-BUFFER buffer from which next-error navigated, and a target buffer TO-BUFFER." :type '(choice (const :tag "No default" ignore) + (const :tag "Quit previous window with M-0" + next-error-quit-window) (function :tag "Other function")) :group 'next-error :version "27.1") --=-=-=--