From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#47368: 28.0.50; map-elt returns nil without "deprecated" TESTFN Date: Fri, 26 Mar 2021 18:57:13 +0000 Message-ID: <87y2e9zqt2.fsf@tcd.ie> References: <87sg4kyw1q.fsf@tcd.ie> <87lfacvtwt.fsf@web.de> <87blb6h8f2.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19218"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Michael Heerdegen , dalanicolai , Nicolas Petton , 47368@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 26 19:58:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPreu-0004sV-T0 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Mar 2021 19:58:12 +0100 Original-Received: from localhost ([::1]:56424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPret-0002PB-Ug for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Mar 2021 14:58:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPrek-0002No-Jy for bug-gnu-emacs@gnu.org; Fri, 26 Mar 2021 14:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59179) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPrek-0002jW-Bc for bug-gnu-emacs@gnu.org; Fri, 26 Mar 2021 14:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lPrek-00063V-9c for bug-gnu-emacs@gnu.org; Fri, 26 Mar 2021 14:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Mar 2021 18:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47368 X-GNU-PR-Package: emacs Original-Received: via spool by 47368-submit@debbugs.gnu.org id=B47368.161678504423224 (code B ref 47368); Fri, 26 Mar 2021 18:58:02 +0000 Original-Received: (at 47368) by debbugs.gnu.org; 26 Mar 2021 18:57:24 +0000 Original-Received: from localhost ([127.0.0.1]:42492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPre7-00062W-KW for submit@debbugs.gnu.org; Fri, 26 Mar 2021 14:57:23 -0400 Original-Received: from mail-wr1-f53.google.com ([209.85.221.53]:47035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPre5-00062H-AE for 47368@debbugs.gnu.org; Fri, 26 Mar 2021 14:57:22 -0400 Original-Received: by mail-wr1-f53.google.com with SMTP id v4so6581931wrp.13 for <47368@debbugs.gnu.org>; Fri, 26 Mar 2021 11:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XYwwPUgb8+OZnrvyMX47TqlaMFLoXwKFpK+P0lg8En8=; b=IWm+Q9K4dT+giX+8Q1GABxT7iz7dWxO5chYKplQNBO8Htq6iblWr6VdXKn/unoZRk+ WWCoApbr7mx/lZ7AAkSdByYAUsMXh/dq1XUiXp9HtDh8KQt8i10KMnTFXldUyVHd+9DW 1A9onr/4WtTPpkyMVtxtCOaf3TYe8YGs3fU4ocp3GOWBuybG9FKuZ0yJgAm7i7lVlkcn ulh3aaeww2HRhpR5e6sNCkTikJiTHD1qZMj0DEDIPE6S4+E2zz0N82qfvFmaL/Oex3y1 oFL4MF6TTeK0acjDN9WGhOsvvS2w8ADH1ol/La3/PVxT+y7mGfYDw3SFfBzVKyzJSjcP SK4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XYwwPUgb8+OZnrvyMX47TqlaMFLoXwKFpK+P0lg8En8=; b=qSPrEXSOXnisvPnBaBgQmIE1Ow1R7hnf+9h0M+kW58j96XVVVFUO0sq0/FjimCCeOp wcjXQluPzAoyE7Ma9SO+NN71JlxXXZjvp2I5cmndSmOkWWnZzHmDSn1cLAAcCHflS6/L 2AOY07RV+/JvVOY/6BhuJLacxnwHRzMSL0lZG7e83DV0EyAB7PsvoGnEt35OWxGn7t8l G08ZkOHxpWrVkTxOVXEgGqmjFKCxuMv+HGntnZ8q7RfhOgsnhFrvMQagxR0bVDYluBZ0 ZJLNkremRJpyKX1DG1rtyJCNot9ZQreAfbfb5KOHRFMUOqD/+J8Cbw0NBfhH5Kk3CObk 14wA== X-Gm-Message-State: AOAM530Ze5z/bgqRVGZo7krQ9sYuRW5I8iAlMTWwxB7mBsnMshtt/ONA xgqKWCBwizJHRj+vVaRWMJwLXg== X-Google-Smtp-Source: ABdhPJx/P8TGgE3e7S19qYeO1/zy4S1SJOl25lvClG2u0bGGW+/SY/AWjMinSVkLDuhoHYe9BWEn5w== X-Received: by 2002:adf:ef4c:: with SMTP id c12mr16195165wrp.112.1616785035481; Fri, 26 Mar 2021 11:57:15 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id h14sm16230400wrq.45.2021.03.26.11.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 11:57:14 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Fri, 26 Mar 2021 09:31:27 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203065 Archived-At: Stefan Monnier writes: >> What's a good way to solve this? Obviously the map abstraction doesn't >> fit so super well for alists because unlike the other map type alists >> don't know "their" test function. But disallowing alists that don't >> test with `eq' seems an unnecessary restriction. Can we say that the >> argument is allowed only for alists? > > How 'bout always using `equal`? No objections here. CCing Nicolas in case he has any comments. Just some code archaeology for more context: - Pre-Emacs-25 map-elt used assoc. - Emacs 25 map-elt used alist-get without TESTFN. - Emacs 26 map-elt gained TESTFN at the same time that alist-get did, in https://bugs.gnu.org/27584. - Emacs 27 deprecated map-elt's TESTFN. -- Basil