From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Date: Sun, 04 Apr 2021 22:17:55 +0200 Message-ID: <87y2dxerd8.fsf@gnus.org> References: <87wntlyhn9.fsf@rfc20.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28008"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: monnier@iro.umontreal.ca, 47552@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 04 22:19:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lT9DI-0007An-Ch for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Apr 2021 22:19:16 +0200 Original-Received: from localhost ([::1]:47038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT9DH-0000Su-4r for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Apr 2021 16:19:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lT9D4-0000Se-Su for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 16:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53220) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lT9D4-0005sd-J0 for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 16:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lT9D4-0005ww-3N for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 16:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Apr 2021 20:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47552 X-GNU-PR-Package: emacs Original-Received: via spool by 47552-submit@debbugs.gnu.org id=B47552.161756749922805 (code B ref 47552); Sun, 04 Apr 2021 20:19:02 +0000 Original-Received: (at 47552) by debbugs.gnu.org; 4 Apr 2021 20:18:19 +0000 Original-Received: from localhost ([127.0.0.1]:36530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9CN-0005vl-0s for submit@debbugs.gnu.org; Sun, 04 Apr 2021 16:18:19 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:50616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9CK-0005vT-AL for 47552@debbugs.gnu.org; Sun, 04 Apr 2021 16:18:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7H/EDtN7+PSufdEur52501VoSFgvnX90Y4yQxgBnkCA=; b=BD/kVpQDgma9mT2eFUXH0RGI1E oWOrHXUPI3FBnrrG/cI/VC9grE7s9jhTk0/UWDU9Mz9q1fR/XGu/u0KRmAay4j8+Ys9ptZlDy02zx LRfuFjXl5lqz8ntLeoHSBo2aaNo/TlJXQhJ5rlgRp/aygKUt9x4Knbnw26zOB7OQxTzc=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lT9C0-0002P1-Dr; Sun, 04 Apr 2021 22:18:09 +0200 X-Now-Playing: JPEGMAFIA's _EP2!_: "THIS ONES FOR US!" In-Reply-To: <87wntlyhn9.fsf@rfc20.org> (Matt Armstrong's message of "Thu, 01 Apr 2021 11:38:34 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203567 Archived-At: Matt Armstrong writes: > I confirmed this in 27 and 28. > > Evaluate these forms in *scratch* or M-x ielm: > > (require 'cl-macs) > (cl-defstruct a gcs-done) > (make-a) > *** Eval error *** Wrong type argument: numberp, nil > > Success is expected, as occurs for structs that don't happen to have > "gcs-done" fields. > > The issue is related to the generated code for `make-a', which boils > down to let binding gcs-done to nil: > > (let ((gcs-done))) > > Eval the above to get the same error. > > Perhaps the code generated for the make- functions should use > make-symbol or gensym instead? Or a fixed series of field0...fieldN > symbols? Why risk potentially binding dynamic vars? Using a gensym seems like an obvious solution to me, but perhaps Stefan has an opinion here (added to the CCs). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no