bug#48049: 28.0.50; X-Draft-From: header missing

bug#48049: 28.0.50; X-Draft-From: header missing

[Adam Sjøgren via Bug reports for GNU Emacs, the Swiss army knife of text editors]

When saving articles in nndraft: Gnus sometimes doesn't insert the
X-Draft-From: header, leading to e.g. delayed articles not being sent
properly

The fix below has been discussed on the Gnus mailing list:

 · https://xref.news/news.gmane.io/gmane.emacs.gnus.general/89808
 · https://xref.news/news.gmane.io/gmane.emacs.gnus.general/89812

Here is a patch that fixes the problem, I have been using it since
January:

--- a/lisp/gnus/gnus-msg.el
+++ b/lisp/gnus/gnus-msg.el
@@ -415,11 +415,12 @@ gnus-setup-message
                             gnus-article-reply)))
           (,oarticle gnus-article-reply)
           (,yanked gnus-article-yanked-articles)
-          (,group (when gnus-article-reply
+          (,group (if gnus-article-reply
                     (or (nnselect-article-group
                          (or (car-safe gnus-article-reply)
                              gnus-article-reply))
-                        gnus-newsgroup-name)))
+                        gnus-newsgroup-name)
+                     gnus-newsgroup-name))
           (message-header-setup-hook
            (copy-sequence message-header-setup-hook))
           (mbl mml-buffer-list)



In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
 of 2021-04-25 built on tullinup
Repository revision: ca153821a30874aca6a7efe5ee7d25607529c47a
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure --with-native-compilation --without-pop --with-kerberos5'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES
NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF
TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Group

Minor modes in effect:
  gnus-topic-mode: t
  gnus-undo-mode: t
  pixel-scroll-mode: t
  engine-mode: t
  global-magit-file-mode: t
  magit-auto-revert-mode: t
  global-git-commit-mode: t
  dumb-jump-mode: t
  shell-dirtrack-mode: t
  which-function-mode: t
  global-auto-complete-mode: t
  save-place-mode: t
  jabber-activity-mode: t
  winner-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t

Load-path shadows:
/usr/share/emacs/site-lisp/elpa-src/boxquote-2.2/boxquote hides ~/elisp/extra/boxquote
~/elisp/let-alist/let-alist hides ~/elisp/extra/let-alist
~/elisp/transient/transient hides /usr/src/emacs/lisp/transient
~/elisp/let-alist/let-alist hides /usr/src/emacs/lisp/emacs-lisp/let-alist

Features:
(shadow sort gnus-cite bbdb-message emacsbug sendmail gnus-topic utf-7
imap rfc2104 epa-file network-stream nsm nnml bbdb-gnus bbdb-mua nnnil
gnus-demon gnus-twit gnus-delay gnus-draft gnus-agent gnus-srvr
gnus-score score-mode nnvirtual nntp gnus-cache nndraft nnmh mail-extr
spam spam-stat bbdb-com gnus-uu yenc gnus-msg gnus-html url-queue
help-fns radix-tree url-cache mm-url bbdb-picture gnus-art mm-uu mml2015
mm-view mml-smime smime dig gnus-sum gnus-group gnus-undo gnus-fun
hashcash gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7
netrc nnoo gnus-spec gnus-int gnus-range gnus-win gnus nnheader time
paren cus-load gopher shr kinsoku svg pixel-scroll litable engine-mode
magithub magithub-ci magithub-issue magithub-cache magithub-core
magit-submodule magit-obsolete magit-popup magit-blame magit-stash
magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone
magit-remote magit-commit magit-sequence magit-notes magit-worktree
magit-tag magit-merge magit-branch magit-reset magit-files magit-refs
magit-status magit magit-repos magit-apply magit-wip magit-log
magit-diff smerge-mode diff magit-core magit-autorevert autorevert
filenotify magit-margin magit-transient magit-process magit-mode
git-commit recentf tree-widget transient magit-git magit-section
benchmark magit-utils pcase vc-git diff-mode ido crm log-edit message
rmc rfc822 mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs
mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util
ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader
pcvs-util with-editor markdown-mode color noutline outline easy-mmode
wgrep-ag wgrep grep deadgrep spinner ag vc-svn compile
text-property-search find-dired dumb-jump f dash s etags fileloop
generator xref project tramp tramp-loaddefs trampver tramp-integration
files-x tramp-compat shell pcomplete parse-time iso8601 ls-lisp
auto-loads tex-site expand-region cperl-mode-expansions
text-mode-expansions html-mode-expansions er-basic-expansions thingatpt
expand-region-core expand-region-custom which-func cperl-mode
auto-complete-config auto-complete popup debian-changelog-mode imenu
add-log dpkg-dev-el saveplace vc vc-dispatcher bbdb derived bbdb-site
timezone bbdb-loaddefs boxquote rect jabber-last-message-correction
jabber-http-file-upload jabber-print-html jabber-otr jabber
jabber-notifications notifications jabber-libnotify dbus jabber-awesome
jabber-osd jabber-wmii jabber-xmessage jabber-festival jabber-sawfish
jabber-ratpoison jabber-tmux jabber-screen jabber-socks5
jabber-ft-server jabber-si-server jabber-ft-client jabber-ft-common
jabber-si-client jabber-si-common jabber-feature-neg jabber-truncate
jabber-time jabber-autoaway time-date jabber-vcard-avatars
jabber-chatstates jabber-events jabber-vcard jabber-avatar
jabber-activity jabber-watch jabber-modeline advice jabber-ahc-presence
jabber-ahc jabber-version jabber-ourversion jabber-muc-nick-completion
hippie-exp comint ansi-color jabber-browse jabber-search jabber-register
jabber-roster format-spec jabber-presence jabber-muc jabber-bookmarks
jabber-private jabber-muc-nick-coloring hexrgb jabber-widget
jabber-disco wid-edit jabber-chat jabber-history jabber-chatbuffer
jabber-alert jabber-iq jabber-core jabber-console sgml-mode facemenu dom
ewoc jabber-keymap jabber-sasl sasl sasl-anonymous sasl-login sasl-plain
fsm jabber-logon jabber-conn srv dns starttls tls jabber-xml xml
jabber-menu jabber-util cl winner ring gnutls puny comp comp-cstr
warnings rx cl-extra help-mode find-file-from-selection find-lisp dired
dired-loaddefs cap-words superword subword edmacro kmacro server
finder-inf package browse-url url url-proxy url-privacy url-expand
url-methods url-history url-cookie url-domsuf url-util mailcap
url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win
x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit x multi-tty make-network-process nativecomp
emacs)

Memory information:
((conses 16 646192 24968)
 (symbols 48 36220 1)
 (strings 32 117921 9241)
 (string-bytes 1 3979029)
 (vectors 16 51423)
 (vector-slots 8 958415 26538)
 (floats 8 478 34)
 (intervals 56 592 77)
 (buffers 992 21))

-- 
 "Här kommer rädslan, nu igen                               Adam Sjøgren
  När alla fjärilar i magen nålas upp                  asjo@koldfront.dk
  till ett mönster på min säng"

bug#48049: 28.0.50; X-Draft-From: header missing

[Lars Ingebrigtsen]

Adam Sjøgren <asjo@koldfront.dk> writes:

> When saving articles in nndraft: Gnus sometimes doesn't insert the
> X-Draft-From: header, leading to e.g. delayed articles not being sent
> properly
>
> The fix below has been discussed on the Gnus mailing list:
>
>  · https://xref.news/news.gmane.io/gmane.emacs.gnus.general/89808
>  · https://xref.news/news.gmane.io/gmane.emacs.gnus.general/89812
>
> Here is a patch that fixes the problem, I have been using it since
> January:

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no