From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Date: Wed, 28 Apr 2021 13:03:37 +0200 Message-ID: <87y2d2brhy.fsf@gmx.de> References: <20210427190243.n5yg3gywd5wma3jl@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28922"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48072@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 28 13:22:55 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbiHO-0007QS-VK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 13:22:54 +0200 Original-Received: from localhost ([::1]:60248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbiHN-0005Ii-TK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 07:22:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbhz8-0007pU-Iq for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 07:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40291) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbhz8-00069X-AK for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 07:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbhz8-0002By-6X for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 07:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Apr 2021 11:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48072-submit@debbugs.gnu.org id=B48072.16196078278405 (code B ref 48072); Wed, 28 Apr 2021 11:04:02 +0000 Original-Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 11:03:47 +0000 Original-Received: from localhost ([127.0.0.1]:51837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbhyt-0002BV-7h for submit@debbugs.gnu.org; Wed, 28 Apr 2021 07:03:47 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:58093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbhyq-0002BF-Ef for 48072@debbugs.gnu.org; Wed, 28 Apr 2021 07:03:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619607818; bh=+0nkS+PovFQXFPXu51Ur+jKx/T/dLFbnjfiuPX/IKRo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=X8XlTyOqDjbv6XiIWRkMp1tLoeAX4yp6fQPe8aLqXJQlEvoJCvv+nGjoXszn6cyHK OijhxnCu9jKXE+WN1MyhBDwsxxNQonh6szqqvmX/tvma9OHAEtTC7PR/LIaUBpS2x6 cIHd6BmKWdOznrJgNgUOA/HzzvKEk17/bgLnW6nQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.147.93]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MDQeK-1lmCNQ1sUI-00AVes; Wed, 28 Apr 2021 13:03:38 +0200 In-Reply-To: <20210427190243.n5yg3gywd5wma3jl@E15-2016.optimum.net> (Boruch Baum's message of "Tue, 27 Apr 2021 15:02:43 -0400") X-Provags-ID: V03:K1:8T+llJu/XyEOjsIYwpfwVgRIC+d6EK3vcYpvNy1k/NLmuX9dIHc Bqj+dgHflALs43LqzS6c6X1AkXVPvSaVFZnfd7v+i18ayDOv0U8hm5vMPk/AvVGVxlAqJt+ 4dhordD+h2kXtVQiR/iYMCYNFPHYA35cEL0oHr2IK4NoyhLr1OrIb43Z53e4q3PIrTS+zxQ IFbtB8tr+sBP9mKRbBIEQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:oWHnHYKkipY=:bArj5FOtOQX5KOYT+eYRhN Dlr37gW2xpXcieowmYLCCLpaycrKWKWPb6W30EYi+CD9pYzaaV63ZHtioJNgHOdnnP39Yy0Qb wr07r1B8FcF1LSPwc+0XPRLO+bF1rk0CnJgEQXZNuQJMMunFfe/7LLvg0qTFI7kY3lSQioiND y2S09paZnEsx4q8rOtn5FoopONfwPRqfQbgEQJNlu+wzx5pFooxqr39eMeSxh+nwvsW3bpVxQ FKdnJhXWuO5td7P9c9nSO4G01QbkzNiGDajpCTQAP+jCQ/c67yYkueDOCIpwqAtpefWJatBzF gqF4hh3JnFYk49NQ3aTgntfA1+aozRmetGbSI/1GhSlWG6IkXpqpxov1+WsF6KdIL4W9l4R52 IooVRaL/gyus/NO9GIfeo+/hAk/DL/iSL2CVonGW0/tNZJpR7nGeO2URr7W9oi0RFooq1N8dX rlACbNy0Fe1SC0o2QxiurkGZneIR2nUDjkKu1y/2X49yRxTmm5m3cSmjtrjOkUcojAhyV4QeK 5GQlb0jY6oaxLv6RWoztyVv6HmgT2yAN6LZfqR0Ri5HV/GjA+JZWJS5yHVdfoRzA1Ipzd1uRK WLZO3nkKBM8A1RHWi5NHCkWMuSW98MKWoUrS+1ojUHgp1Au06LLJ67NWE33GfmQwSEnkj4Q/M tmwH2+tD6kBhqLJtNaqOVlpsZS3xVyKFKHbHhO1hYxy5lcIhZexYOGhoujQ0z79/eruzc8FuL 2G61Hb9Bp5mXcbVhg9neFBeVfzgyL10uYwvqvppR7LjwnIHfcnk5aEGH7vl09M2GM4HmCLTC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205093 Archived-At: Boruch Baum writes: Hi, > The attached patch fixes that, and also validates the entered command as > a valid shell executable. > > + (unless (executable-find command) > + (user-error "Not a valid command!")) This doesn't check the remote case. Best regards, Michael.