From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#37609: Tool-bar-mode grows the frame's height Date: Wed, 05 May 2021 23:37:58 +0300 Organization: LINKOV.NET Message-ID: <87y2ctf3td.fsf@mail.linkov.net> References: <87bluxihw0.fsf@mail.linkov.net> <507f8fc7-651a-12ea-20e6-bf2092ab5ed1@gmx.at> <87y2cub2gf.fsf@mail.linkov.net> <332adca2-1088-3dc6-d18f-778b73b24e0c@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19311"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 37609@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 05 23:01:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leOdn-0004ua-75 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 23:01:07 +0200 Original-Received: from localhost ([::1]:56086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leOdl-0001iB-Fr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 17:01:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leOcn-0001gh-2Z for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 17:00:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51137) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leOcl-0005yx-Ct for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 17:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leOcl-0004Us-CO for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 17:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 21:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37609 X-GNU-PR-Package: emacs Original-Received: via spool by 37609-submit@debbugs.gnu.org id=B37609.162024835917194 (code B ref 37609); Wed, 05 May 2021 21:00:03 +0000 Original-Received: (at 37609) by debbugs.gnu.org; 5 May 2021 20:59:19 +0000 Original-Received: from localhost ([127.0.0.1]:34443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leOc2-0004TB-SE for submit@debbugs.gnu.org; Wed, 05 May 2021 16:59:19 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:42967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leObz-0004Sm-Ju for 37609@debbugs.gnu.org; Wed, 05 May 2021 16:59:16 -0400 X-Originating-IP: 91.129.102.166 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 2D4652000A; Wed, 5 May 2021 20:59:08 +0000 (UTC) In-Reply-To: <332adca2-1088-3dc6-d18f-778b73b24e0c@gmx.at> (martin rudalics's message of "Wed, 5 May 2021 09:24:48 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205739 Archived-At: >>> Can you please check again? > > Did you check with Lucid? In Lucid ((outer-size 696 . 706) (outer-size 696 . 706)) >> Now the frame's height doesn't grow but shrinks on GTK: >> >> ((outer-size 694 . 690) (outer-size 694 . 738)) > > Here when I start a GTK3 build with > > emacs -Q -f tool-bar-mode > > and do > > (let ((initial (assq 'outer-size (frame-geometry)))) > (tool-bar-mode 1) > (tool-bar-mode 0) > (list (assq 'outer-size (frame-geometry)) initial)) > > I get > > ((outer-size 762 . 697) (outer-size 762 . 697)) > > an invariable frame height of 36, a frame pixel height of 648 (which > sums up correctly with a menu bar height of 25, a title bar height of 14 > and an external border of 5 pixels) and no visible change of any kind. I get in a GTK3 build ((outer-size 694 . 690) (outer-size 694 . 690)) (frame-height) 36 >> Do you think now it's improved? > > It's up to you to decide. I can try to fix all inconsistencies you > still see. Thanks. > As far as outer sizes are concerned be aware that snippets like > > (progn > (tool-bar-mode 1) > (assq 'outer-size (frame-geometry))) > > might not tell the whole truth because the frame geometry may not have > changed yet at the time you call that function. And please make sure > to associate every result you report with the corresponding toolkit. Noted 👍.