From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#48179: bookmark-fontify [PATCH] Date: Thu, 06 May 2021 19:53:18 +0100 Message-ID: <87y2cru21t.fsf@tcd.ie> References: <20210503091204.qhc2tda76wh6345w@E15-2016.optimum.net> <87im40cgxz.fsf@gnus.org> <20210503095828.66mcqkxyznb2vdja@E15-2016.optimum.net> <87v97yan85.fsf@gnus.org> <87lf8uan2m.fsf@gnus.org> <87zgxan7lx.fsf@tcd.ie> <878s4t8up2.fsf@gnus.org> <8735v1jrit.fsf@tcd.ie> <20210505170853.locsnpxoth7fukeq@E15-2016.optimum.net> <87fsz01bo7.fsf@gnus.org> <20210506103835.iyo6ff4rwuzgbpxd@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18407"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 48179@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 20:54:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lej8Z-0004fN-5F for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 20:54:15 +0200 Original-Received: from localhost ([::1]:52526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lej8Y-0004CZ-8l for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 14:54:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lej8M-0004CD-B6 for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 14:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lej8M-0003id-4R for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 14:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lej8M-0006ha-3e for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 14:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 18:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 48179-submit@debbugs.gnu.org id=B48179.162032720925751 (code B ref 48179); Thu, 06 May 2021 18:54:02 +0000 Original-Received: (at 48179) by debbugs.gnu.org; 6 May 2021 18:53:29 +0000 Original-Received: from localhost ([127.0.0.1]:39094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lej7p-0006hH-1h for submit@debbugs.gnu.org; Thu, 06 May 2021 14:53:29 -0400 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:42914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lej7l-0006h7-IE for 48179@debbugs.gnu.org; Thu, 06 May 2021 14:53:27 -0400 Original-Received: by mail-wr1-f46.google.com with SMTP id l2so6686471wrm.9 for <48179@debbugs.gnu.org>; Thu, 06 May 2021 11:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/aCTpE0pbDOalG/bG+8BCC32nVdQSa1omyby9eq2AuA=; b=K2XNPGy77A0+SA5egUs0kyZfCKLBVN7bA1fhm2Ib/a2BlO91JMdHkbFADE2N9voKV2 7ku8/8uCn+zuFPWfMnctWf/V+pqOtur7ioLBwM3/kRlzDATWqOiSCNV0mhn7/rpiR/YY 5Xe5xOv25TIaE3Wp//OB93Xus002pma8QD2qAmy2v90QwDDP065EEnRKBCbbDBXK6EDs 3GLe3d+gAd8NFmK13MfScre2NcNE78DRaJCSmApRubfwruXHCmDEeHyBUb+ifMJrD8rw ZC74iYGZM5wV0w3glmiSV1PCMbGn+sC/jm/oWZSyRBYyux/QO77mWwYnI/T32tmn7ES0 cssA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/aCTpE0pbDOalG/bG+8BCC32nVdQSa1omyby9eq2AuA=; b=qalN1DwNIH599wlkyutH5gWX9i+D3oyCK4fsX6oOYlr27V+/xAw0gcbhwbn9yMP+uT 5vpatJxhOgRNSssGab8ZxLVaDESeHAYmdYN3Vu3v18T+0/d3Ng5HcHfXousB/2f45yAW KRtp0njQRPbW6PvfCgs7vGDLA2mAb2LlHaKgUlD7sPknNDTzfVRU0jzt2AHKb8+bFid1 1cmjfiG5mPiJxoxhGbeweM/zHpvO0WMyt/U+s2k0pvtCJj9HDprkG7uG39CHOmg1gPRm bRiuQNmPz9D4IbYqRHolQp3zat3icEkFxD0Uh28YOQiGBc3ue3X30f3o3eymsovR1Dnx OlCA== X-Gm-Message-State: AOAM530ueqiNeGh0QE5gg9UMLFMUinrYFhY4wIi+7pI9sZQFdBQmp+G+ H8aQ3/72k4FeTpBsRt0FjsCDu2aqpD2tBg== X-Google-Smtp-Source: ABdhPJxN5FRwkvSwkgKYWpCSk0SUzAZhY1xCgp4yDevEgu90e3ySe5AIoQOBOf3XQ+46tVZGTussYA== X-Received: by 2002:a05:6000:180a:: with SMTP id m10mr7145347wrh.215.1620327199963; Thu, 06 May 2021 11:53:19 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id l14sm5881130wrv.94.2021.05.06.11.53.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 11:53:19 -0700 (PDT) In-Reply-To: <20210506103835.iyo6ff4rwuzgbpxd@E15-2016.optimum.net> (Boruch Baum's message of "Thu, 6 May 2021 06:38:35 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205873 Archived-At: Boruch Baum writes: > On 2021-05-06 10:58, Lars Ingebrigtsen wrote: >> Boruch Baum writes: >> >> > 5) Throughout my prior patches, I had been using variable >> > 'buffer-file-name' to compare against the value for the 'filename' >> > key in bookmarks' alists. That is wrong, in the sense that it's only >> > correct for buffers visiting files. The correct comparator seems to >> > be the output of function (bookmark-buffer-file-name), see there, >> > which will cover all cases of all buffers. With that change, it's >> > probably wrong to perform 'expand-file-name' when performing any >> > comparison. >> >> Right. Can you submit a patch to fix that? > > Basil has taken the lead on this, He's not taken the lead on this, he's just a very naughty boy. > and I'm waiting on a response from him > with his integration patch before continuing. ??? :) > Once that happens, I'll suggest to him that patch and one or two other > ideas (eg. a setting change should be respected immediately across all > buffers, so it should be controlled by a toggle or -mode command; > popping a bookmark should fontify the pop). I suggest that you suggest all of that to this list instead ;). -- Basil