From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#48478: 28.0.50; yank-from-kill-ring and kill-ring-yank-pointer Date: Thu, 27 May 2021 01:09:33 +0300 Organization: LINKOV.NET Message-ID: <87y2c1yvqq.fsf@mail.linkov.net> References: <83h7j1twym.fsf@gnu.org> <874kf1yq92.fsf@mail.linkov.net> <83o8d8s1jd.fsf@gnu.org> <878s4bzt6v.fsf@mail.linkov.net> <83fsyjqwtr.fsf@gnu.org> <87h7iyn0s5.fsf@mail.linkov.net> <831ra1px7n.fsf@gnu.org> <875yzdb7vz.fsf@mail.linkov.net> <83lf89ns51.fsf@gnu.org> <87eee19o24.fsf@mail.linkov.net> <83fsyhnp2r.fsf@gnu.org> <871ra19luh.fsf@mail.linkov.net> <83cztkocqt.fsf@gnu.org> <87h7iwuf0m.fsf@mail.linkov.net> <83o8d3l179.fsf@gnu.org> <87k0nqo570.fsf@mail.linkov.net> <83a6olkjca.fsf@gnu.org> <87pmxe649v.fsf@mail.linkov.net> <835yz5bszn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11780"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 48478@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 27 00:33:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lm25O-0002zF-Qg for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 May 2021 00:33:10 +0200 Original-Received: from localhost ([::1]:47972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lm25N-0000zT-ST for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 May 2021 18:33:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lm25G-0000z4-HP for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 18:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lm25G-0000ok-9C for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 18:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lm25G-0001mc-5O for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 18:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 May 2021 22:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48478 X-GNU-PR-Package: emacs Original-Received: via spool by 48478-submit@debbugs.gnu.org id=B48478.16220683225130 (code B ref 48478); Wed, 26 May 2021 22:33:02 +0000 Original-Received: (at 48478) by debbugs.gnu.org; 26 May 2021 22:32:02 +0000 Original-Received: from localhost ([127.0.0.1]:50165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lm24I-0001KL-2t for submit@debbugs.gnu.org; Wed, 26 May 2021 18:32:02 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:9671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lm24F-0001ER-KT for 48478@debbugs.gnu.org; Wed, 26 May 2021 18:31:59 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 11C83240006; Wed, 26 May 2021 22:31:52 +0000 (UTC) In-Reply-To: <835yz5bszn.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 26 May 2021 15:05:16 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207329 Archived-At: >> > If you want yank-from-kill-ring to leave kill-ring-yank-pointer >> > unaltered, we could move the pointer in yank-pop, after >> > yank-from-kill-ring returns. WDYT? >> >> When yank-from-kill-ring returns an edited string, > > When does it do that? AFAICT, it _inserts_ the edited string. Sorry, I meant this: When read-from-kill-ring returns an edited string, how yank-from-kill-ring could use it to adjust kill-ring-yank-pointer? > yank-from-kill-ring is a new function, and its return value isn't > documented. So you could change it to return kill-ring-yank-pointer > instead, and then yank-pop could move it. I don't understand what value of kill-ring-yank-pointer should be returned: its old value or some modified value? BTW, the recent fix in ef7a6eec20 broke such use case: M-w on some region, but then M-y M-p doesn't insert the last item to the minibuffer, i.e. the same item that is inserted to the buffer by C-y. Here is a workaround: diff --git a/lisp/simple.el b/lisp/simple.el index 0d4a712b39..7014f1c24c 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -5735,7 +5736,8 @@ read-from-kill-ring (complete-with-action action completions string pred))) nil nil nil (if history-pos - (cons 'read-from-kill-ring-history (1+ history-pos)) + (cons 'read-from-kill-ring-history + (if (zerop history-pos) history-pos (1+ history-pos))) 'read-from-kill-ring-history)))))