From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Allen Li <vianchielfaura@gmail.com>,
30056@debbugs.gnu.org, Glenn Morris <rgm@gnu.org>
Subject: bug#30056: 25.3; battery-mode-line-string missing leading space
Date: Tue, 27 Jul 2021 02:09:27 +0300 [thread overview]
Message-ID: <87y29s7jep.fsf@mail.linkov.net> (raw)
In-Reply-To: <87r1fo2agu.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 24 Jul 2021 13:54:41 +0200")
>> This change broke tab-bar.el that expected that the default value of
>> mode-line-misc-info contains (global-mode-string ("" global-mode-string " ")).
>
> I've now updated the code in tab-bar.el. But isn't that a brittle way
> to enable this? The user may have altered the variable value, for instance.
This code is just for convenience to avoid duplication of the global string
on the mode-line and on the tab-bar. When the user alters mode-line-misc-info
manually, then we can assume that the user does this intentionally,
e.g. to force duplication of the global string, etc.
But the default value of mode-line-misc-info doesn't change too often,
so there is no problem.
However, there is another problem: now display-time-string contains
additional trailing space, so when time is displayed on the
right edge on the tab-bar, time string is not aligned nicely anymore.
Now there is the gap between the time string and the right edge of the tab-bar.
How this could be avoided? Maybe tab-bar-format-global now needs
to use 'string-trim' on the result of '(format-mode-line global-mode-string)'?
next prev parent reply other threads:[~2021-07-26 23:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 3:26 bug#30056: 25.3; battery-mode-line-string missing leading space Allen Li
2018-01-10 8:45 ` bug#30056: [PATCH] Add leading space to battery-mode-line-format Allen Li
2018-01-10 15:29 ` bug#30056: 25.3; battery-mode-line-string missing leading space Eli Zaretskii
2018-01-10 17:06 ` Glenn Morris
2018-01-10 19:05 ` Eli Zaretskii
2018-01-10 23:26 ` Allen Li
2018-01-11 15:57 ` Eli Zaretskii
2018-01-12 8:18 ` Allen Li
2020-08-10 13:43 ` Lars Ingebrigtsen
2020-08-11 8:40 ` Allen Li
2020-08-11 11:19 ` Lars Ingebrigtsen
2020-08-12 7:31 ` Allen Li
2021-07-22 14:15 ` Lars Ingebrigtsen
2021-07-23 12:48 ` Lars Ingebrigtsen
2021-07-23 18:23 ` Juri Linkov
2021-07-24 11:54 ` Lars Ingebrigtsen
2021-07-26 23:09 ` Juri Linkov [this message]
2021-07-27 20:56 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y29s7jep.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=30056@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=rgm@gnu.org \
--cc=vianchielfaura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).