unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
	Noam Postavsky <npostavs@gmail.com>,
	39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de
Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards
Date: Fri, 27 Aug 2021 09:05:31 +0300	[thread overview]
Message-ID: <87y28nbky4.fsf@linkov.net> (raw)
In-Reply-To: <2602aeaf-0f02-e744-2b4f-012e73e012e8@yandex.ru> (Dmitry Gutov's message of "Sun, 15 Aug 2021 04:25:20 +0300")

>> If we've seen one piece of code break here already, then perhaps
>> reverting and moving to the other (safer, but more invasive) approach is
>> the right way to go.
>
> Fair enough.
>
> Pushed the other patch with a couple of small tweaks.

This broke vc-rename-file that now fails with

  (error Failed (status 128): git --no-pager mv -f -- :(literal)/tmp/gitrepo/subdir/file1 :(literal)/tmp/gitrepo/subdir/file2)
  fatal: bad source, source=subdir/:(literal)/tmp/gitrepo/subdir/file1, destination=subdir/:(literal)/tmp/gitrepo/subdir/file2

Can be fixed with

diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index 02ca022ad4..88e015fc9d 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -1559,7 +1559,7 @@ vc-git-delete-file
   (vc-git-command nil 0 (vc-git--literal-pathspecs file) "rm" "-f" "--"))
 
 (defun vc-git-rename-file (old new)
-  (vc-git-command nil 0 (vc-git--literal-pathspecs (list old new)) "mv" "-f" "--"))
+  (vc-git-command nil 0 (list old new) "mv" "-f" "--"))
 
 (defun vc-git-mark-resolved (files)
   (vc-git-command nil 0 (vc-git--literal-pathspecs files) "add"))





  reply	other threads:[~2021-08-27  6:05 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06 13:59 bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Wolfgang Scherer
2020-02-06 23:00 ` Dmitry Gutov
2020-02-07  7:57   ` Eli Zaretskii
2020-02-07  8:43     ` Dmitry Gutov
2020-02-07  9:26       ` Eli Zaretskii
2020-02-07 11:43         ` Dmitry Gutov
2020-02-07 14:43       ` Noam Postavsky
2020-02-11 23:01         ` Dmitry Gutov
2020-02-12 15:24           ` Noam Postavsky
2021-05-12 16:04             ` Lars Ingebrigtsen
2021-05-17  1:05               ` Dmitry Gutov
2021-07-22 12:42                 ` Lars Ingebrigtsen
2021-08-14  0:11                   ` Dmitry Gutov
2021-08-14 11:56                     ` Lars Ingebrigtsen
2021-08-15  1:25                       ` Dmitry Gutov
2021-08-27  6:05                         ` Juri Linkov [this message]
2021-08-27 12:51                           ` Dmitry Gutov
2021-08-27 17:10                             ` Juri Linkov
2021-08-27 19:57                               ` Stephen Berman
2021-08-28 15:07                                 ` Lars Ingebrigtsen
2021-08-28 15:44                                   ` Stephen Berman
2021-08-28 15:48                                     ` Lars Ingebrigtsen
2021-08-28 16:02                                       ` Stephen Berman
2021-08-28 22:19                                       ` Dmitry Gutov
2021-08-30  2:36                                 ` Dmitry Gutov
2021-08-30 13:34                                   ` Stephen Berman
2021-08-30 23:48                                     ` Dmitry Gutov
2021-08-27 22:47                               ` Dmitry Gutov
2021-08-29  0:18                             ` Dmitry Gutov
2021-08-29 16:44                               ` Juri Linkov
2021-08-29 19:50                                 ` Dmitry Gutov
2021-08-29 19:57                                   ` Lars Ingebrigtsen
2021-08-29 20:11                                     ` Dmitry Gutov
2020-02-13 18:34           ` Wolfgang Scherer
2020-02-13 23:23             ` Dmitry Gutov
2020-02-14  9:37               ` Eli Zaretskii
2020-02-14 13:59                 ` Dmitry Gutov
2020-02-14 14:14                   ` Eli Zaretskii
2020-02-14 14:40                     ` Dmitry Gutov
2020-02-14 15:45                       ` Eli Zaretskii
2020-02-14 20:37                         ` Dmitry Gutov
2020-09-20  9:54               ` Lars Ingebrigtsen
2020-02-07 17:25   ` Wolfgang Scherer
2020-02-07 22:31     ` Wolfgang Scherer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y28nbky4.fsf@linkov.net \
    --to=juri@linkov.net \
    --cc=39452@debbugs.gnu.org \
    --cc=Wolfgang.Scherer@gmx.de \
    --cc=dgutov@yandex.ru \
    --cc=larsi@gnus.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).