From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Dieter Wilhelm <dieter@duenenhof-wilhelm.de>,
Dan Nicolaescu <dann@ics.uci.edu>,
Stefan Monnier <monnier@IRO.UMontreal.CA>,
4179@debbugs.gnu.org
Subject: bug#4179: vc-merge with svn: syntax error in revision arg.
Date: Sun, 29 Aug 2021 22:42:10 +0200 [thread overview]
Message-ID: <87y28kaspp.fsf@gnus.org> (raw)
In-Reply-To: <7f7b777c-1ae1-8ca7-bc5c-80f19baba0e6@yandex.ru> (Dmitry Gutov's message of "Sun, 29 Aug 2021 03:50:04 +0300")
Dmitry Gutov <dgutov@yandex.ru> writes:
> Hard for me to say: it's SVN. Someone who has easy access to such a
> server should try the original scenario.
>
> But there have indeed been some changes, including commit
> d17bae903902. Which mentions fixing "a layering violation that caused
> bad behavior with SVN".
OK; I think we can close this bug report, then. (Now done.)
>> The comment there is wrong -- it's no longer used in vc.el. Perhaps
>> these two functions should be moved to vc-rcs.el (and renamed (with
>> obsolete aliases))? (They're only used in vc-rcs.el and vc-vcs.el.)
>
> Yes, they should.
Also done.
> Also, vc-merge should call (vc-find-backend-function
> backend 'merge-file) instead of (vc-find-backend-function backend
> 'merge). They only seem equivalent for now by lucky accident. I'd do
> that change myself now, but it's similarly hard for me to quickly test
> any of the affected backends, and this operation is not covered by
> vc-tests.el.
Perhaps open a new bug report for this and see whether anybody
volunteers to implement and test?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-08-29 20:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 17:34 bug#4179: vc-merge with svn: syntax error in revision arg Dieter Wilhelm
2009-08-20 2:59 ` Dan Nicolaescu
2009-08-25 18:06 ` Stefan Monnier
2009-08-26 18:04 ` Dan Nicolaescu
2021-08-27 3:06 ` Lars Ingebrigtsen
2021-08-27 20:11 ` H. Dieter Wilhelm
2021-08-29 0:50 ` Dmitry Gutov
2021-08-29 20:42 ` Lars Ingebrigtsen [this message]
2021-08-29 21:09 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y28kaspp.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=4179@debbugs.gnu.org \
--cc=dann@ics.uci.edu \
--cc=dgutov@yandex.ru \
--cc=dieter@duenenhof-wilhelm.de \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).