From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#50256: thing-at-mouse Date: Thu, 02 Sep 2021 21:28:32 +0300 Organization: LINKOV.NET Message-ID: <87y28e4ysv.fsf@mail.linkov.net> References: <87sfys6ubm.fsf@mail.linkov.net> <871r6a8ooe.fsf@gnus.org> <87y28i85xi.fsf@mail.linkov.net> <87k0k1o5ks.fsf@mail.linkov.net> <87ilzk6bsr.fsf@mail.linkov.net> <6dcf3191-dbb3-0c6c-2483-0fc05e9ff6e5@gmx.at> <83lf4gqyn9.fsf@gnu.org> <1a65f234-c1ee-ae95-aa05-2e3d9d1e1002@gmx.at> <8335qoqobm.fsf@gnu.org> <7c9cb0a1-b222-cb06-7e7c-7f17231faca3@gmx.at> <83pmtsp4g1.fsf@gnu.org> <831r67ph8d.fsf@gnu.org> <87tuj3bffb.fsf@gnus.org> <83y28fo1xf.fsf@gnu.org> <191e9cc6-7370-5b7d-7777-716b61e0155d@gmx.at> <83pmtrnydh.fsf@gnu.org> <158a8854-f56a-9aaa-3a14-d108e086a24c@gmx.at> <83k0jznms2.fsf@gnu.org> <87v93j9dfz.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27242"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 50256@debbugs.gnu.org, larsi@gnus.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 02 20:30:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLrTg-0006tv-72 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 20:30:20 +0200 Original-Received: from localhost ([::1]:51714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLrTe-000235-VH for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 14:30:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLrTO-00022N-AE for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 14:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58718) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLrTO-0001XJ-25 for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 14:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mLrTN-0001yo-RW for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 14:30:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Sep 2021 18:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50256 X-GNU-PR-Package: emacs Original-Received: via spool by 50256-submit@debbugs.gnu.org id=B50256.16306073677529 (code B ref 50256); Thu, 02 Sep 2021 18:30:01 +0000 Original-Received: (at 50256) by debbugs.gnu.org; 2 Sep 2021 18:29:27 +0000 Original-Received: from localhost ([127.0.0.1]:42028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLrSo-0001xN-Q9 for submit@debbugs.gnu.org; Thu, 02 Sep 2021 14:29:26 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLrSk-0001x7-Pg for 50256@debbugs.gnu.org; Thu, 02 Sep 2021 14:29:25 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id A49FCFF807; Thu, 2 Sep 2021 18:29:14 +0000 (UTC) In-Reply-To: <87v93j9dfz.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 02 Sep 2021 18:58:40 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213298 Archived-At: >> I mean that we needn't do that because pos_visible_p already does it. >> So I'd just propose to do the trivial (line numbers are not trunk's); >> >> diff --git a/src/window.c b/src/window.c >> index cb8fe5fcdb..bfbed01749 100644 >> --- a/src/window.c >> +++ b/src/window.c >> @@ -2199,8 +2199,6 @@ DEFUN ("pos-visible-in-window-p", Fpos_visible_in_window_p, >> posint = -1; >> else if (!NILP (pos)) >> posint = fix_position (pos); >> - else if (w == XWINDOW (selected_window)) >> - posint = PT; >> else >> posint = marker_position (w->pointm); > > I confirm this fixes the reported issues. Actually, whereas it fixes the reported issue, it breaks everything else: moving point up and down always jumps to the fixed column like goal-column, selecting a completion from the Completions buffer always says "No completion here", 'C-c C-c' in diff-mode jumps to the wrong hunk, etc.