From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#50344: C-x v keybinding for vc-print-branch-log Date: Sun, 05 Sep 2021 19:28:06 +0300 Organization: LINKOV.NET Message-ID: <87y28burzd.fsf@mail.linkov.net> References: <87mtoux1ha.fsf@mail.linkov.net> <1f39aa34-6626-3d0b-d764-2c9908787d99@yandex.ru> <87o8998wf4.fsf@mail.linkov.net> <84e4e2ef-6c8d-3645-9e1e-3129981dd45f@yandex.ru> <875yvgvohe.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2291"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 50344@debbugs.gnu.org, Dmitry Gutov To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 05 18:42:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMvDj-0000TX-3o for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Sep 2021 18:42:15 +0200 Original-Received: from localhost ([::1]:42856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMvDh-0000Ae-Sx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Sep 2021 12:42:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMvDY-0008U3-DD for bug-gnu-emacs@gnu.org; Sun, 05 Sep 2021 12:42:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39341) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMvDY-00073g-4v for bug-gnu-emacs@gnu.org; Sun, 05 Sep 2021 12:42:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mMvDY-0008Ey-3A for bug-gnu-emacs@gnu.org; Sun, 05 Sep 2021 12:42:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Sep 2021 16:42:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50344 X-GNU-PR-Package: emacs Original-Received: via spool by 50344-submit@debbugs.gnu.org id=B50344.163086011831622 (code B ref 50344); Sun, 05 Sep 2021 16:42:04 +0000 Original-Received: (at 50344) by debbugs.gnu.org; 5 Sep 2021 16:41:58 +0000 Original-Received: from localhost ([127.0.0.1]:50880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMvDR-0008Dy-Vm for submit@debbugs.gnu.org; Sun, 05 Sep 2021 12:41:58 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:60199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMvDQ-0008DS-Mq for 50344@debbugs.gnu.org; Sun, 05 Sep 2021 12:41:57 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 1F5BBC0004; Sun, 5 Sep 2021 16:41:48 +0000 (UTC) In-Reply-To: <875yvgvohe.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 04 Sep 2021 08:33:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213512 Archived-At: >>> I think we want more to remove another duplicate key 'C-x v s' >>> because then we could bind it to 'vc-log-search'. >> >> That works for me. And indeed vc-log-search seems more important. >> >> What do others think? > > Then it would be only on `B c' in vc-dir-mode? `C-x v s' isn't very > mnemonic, but would removing it from global map inconvenience people? > (I've never used it myself.) Indeed, it seems there is no way to remove old keybindings, especially by rebinding them to other commands, so I propose to add new keybindings: diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el index 4b3c829a2c..4d3f642796 100644 --- a/lisp/vc/vc-hooks.el +++ b/lisp/vc/vc-hooks.el @@ -865,6 +865,9 @@ vc-prefix-map (let ((map (make-sparse-keymap))) (define-key map "a" #'vc-update-change-log) (define-key map "b" #'vc-switch-backend) + (define-key map "Bc" #'vc-create-tag) + (define-key map "Bl" #'vc-print-branch-log) + (define-key map "Bs" #'vc-retrieve-tag) (define-key map "d" #'vc-dir) (define-key map "g" #'vc-annotate) (define-key map "G" #'vc-ignore) @@ -879,6 +882,7 @@ vc-prefix-map (define-key map "m" #'vc-merge) (define-key map "r" #'vc-retrieve-tag) (define-key map "s" #'vc-create-tag) + (define-key map "S" #'vc-log-search) (define-key map "u" #'vc-revert) (define-key map "v" #'vc-next-action) (define-key map "+" #'vc-update)