From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41343: tab-bar-mode: Close tab on mouse-2 click Date: Sun, 05 Sep 2021 20:17:20 +0300 Organization: LINKOV.NET Message-ID: <87y28brlgf.fsf@mail.linkov.net> References: <87wnp2cg52.fsf@linkov.net> <83tuk5la2u.fsf@gnu.org> <877dh18lj3.fsf@mail.linkov.net> <83y29gjvjh.fsf@gnu.org> <8735rn8jz6.fsf@mail.linkov.net> <83sfznhywm.fsf@gnu.org> <87tuk356ia.fsf@mail.linkov.net> <83im0iiw8n.fsf@gnu.org> <877dgvkt1z.fsf@mail.linkov.net> <83wnotfpak.fsf@gnu.org> <87k0ksecbq.fsf@mail.linkov.net> <83v94cdwk5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16411"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41343@debbugs.gnu.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 05 19:20:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMvoh-0004A1-4l for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Sep 2021 19:20:27 +0200 Original-Received: from localhost ([::1]:40108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMvof-0002ad-CG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Sep 2021 13:20:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMvoI-0002aO-Sk for bug-gnu-emacs@gnu.org; Sun, 05 Sep 2021 13:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39389) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMvoH-00054L-SN for bug-gnu-emacs@gnu.org; Sun, 05 Sep 2021 13:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mMvoH-0000h2-LX for bug-gnu-emacs@gnu.org; Sun, 05 Sep 2021 13:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Sep 2021 17:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41343 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41343-submit@debbugs.gnu.org id=B41343.16308623692607 (code B ref 41343); Sun, 05 Sep 2021 17:20:01 +0000 Original-Received: (at 41343) by debbugs.gnu.org; 5 Sep 2021 17:19:29 +0000 Original-Received: from localhost ([127.0.0.1]:50932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMvnl-0000fz-67 for submit@debbugs.gnu.org; Sun, 05 Sep 2021 13:19:29 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:59039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMvnj-0000fl-TS for 41343@debbugs.gnu.org; Sun, 05 Sep 2021 13:19:28 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 5CE821BF206; Sun, 5 Sep 2021 17:19:20 +0000 (UTC) In-Reply-To: <83v94cdwk5.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 11 Aug 2021 14:56:26 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213520 Archived-At: >> Could you please help to check if everything is correct >> on the Windows part (unfortunately, I don't have Windows). >> The changes in w32inevt.c and w32term.c just mirror the changes >> in xdisp.c and xterm.c, but I'm sure I might have made a typo. > > I will, if you tell me what to try after applying the patch. Now the branch 'feature/tab-bar-events' is ready for merging to master. What remains to do is to test it on Windows. Could you please try on Windows GUI and on Windows console to use mouse-1 to select a tab, to click mouse-1 a close button to close it, to drag a tab by mouse-1, to click mouse-2 to close the clicked tab, mouse-3 to pop up the context menu and select "Close", and also wheel-left/wheel-right to switch to the next/previous tab, and S-wheel-left/wheel-right to move the tab.