From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50435: 27.2; browse-url-encode-url not encoding spaces Date: Tue, 07 Sep 2021 17:47:11 +0200 Message-ID: <87y288bd6o.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17483"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50435@debbugs.gnu.org To: Howard Melman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 07 17:50:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNdMk-0004MD-94 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Sep 2021 17:50:30 +0200 Original-Received: from localhost ([::1]:52994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNdMj-0006Bq-AI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Sep 2021 11:50:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNdKM-00025D-Po for bug-gnu-emacs@gnu.org; Tue, 07 Sep 2021 11:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45888) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNdKM-0008SC-GI for bug-gnu-emacs@gnu.org; Tue, 07 Sep 2021 11:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNdKM-0003RP-E9 for bug-gnu-emacs@gnu.org; Tue, 07 Sep 2021 11:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Sep 2021 15:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50435 X-GNU-PR-Package: emacs Original-Received: via spool by 50435-submit@debbugs.gnu.org id=B50435.163102965112369 (code B ref 50435); Tue, 07 Sep 2021 15:48:02 +0000 Original-Received: (at 50435) by debbugs.gnu.org; 7 Sep 2021 15:47:31 +0000 Original-Received: from localhost ([127.0.0.1]:57434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNdJr-0003Cx-7h for submit@debbugs.gnu.org; Tue, 07 Sep 2021 11:47:31 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:49018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNdJg-00030g-7R for 50435@debbugs.gnu.org; Tue, 07 Sep 2021 11:47:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uYjQokRhtwd3QLt65HH4h2Gniky1CSYvBH1H7SzVPA0=; b=Kq9JYoZeqC2vMozWka9kuZlDJr KemQsZqz1Dy/F0RYdufhMPjApYE6Ebi+VTPipooxs6jJ0C9LiwPJgGX8EePgB8LIZ9FiSl7h+PjBV 1A9xamZKH/AThmximHz6mNPtQuQXLnuLbz+As2tHWEJ41AZYFAev1LhEBhkNAF8+GQQQ=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNdJX-0007WY-H6; Tue, 07 Sep 2021 17:47:14 +0200 In-Reply-To: (Howard Melman's message of "Mon, 6 Sep 2021 14:06:33 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213705 Archived-At: Howard Melman writes: > I may be misunderstanding something, but > browse-url-encode-url does not encode spaces. > > (browse-url-encode-url "foo bar") > > returns "foo bar" and I think it should return "foo%20bar" > > It looks like a simple typo in browse-url-encode-url since it calls: > > (browse-url-url-encode-chars url "[\")$] ")) > > I think the space should be before the ], but from what I can > tell it's been that way since 2012. browse-url-url-encode-chars was documented to take a string of characters to translate, but used it as a regexp. I've now fixed the documentation and `browse-url-encode-url'. > Also browse-url-encode-url is used in several browser > specific browse-url functions like browse-url-netscape and > browse-url-firefox but not in > browse-url-default-windows-browser and > browse-url-default-macosx-browser. Is this intentional? > I'm on a mac (using the macport) and it seems frustrating. I've now fixed this in Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no