From: Jonas Bernoulli <jonas@bernoul.li>
To: 50511@debbugs.gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#50511: 27.2; url-http-handle-authentication should not raise error
Date: Fri, 10 Sep 2021 18:14:54 +0200 [thread overview]
Message-ID: <87y284l85d.fsf@bernoul.li> (raw)
Since [1: 64b469f6ae] url-http-handle-authentication raises an error
when it detects that we already tried to make an authenticated request.
1: 2019-07-26 64b469f6ae8173116ec948ac43cd44efe4b5a221
Don't infloop in url.el when sending invalid basic auth
Instead of signaling an error using `error', it should simply return t
to indicate that no further requests should be made and the response
data (in this case error data) should be passed to the handler, i.e. to
indicate that the request "successfully failed". Then the error handler
can inspect the response and decide how to react.
This is how it is done for all other https response codes, including all
other error codes. This approach also solves the infloop issue but also
makes it possible to use an error handler as intended.
Jonas
next reply other threads:[~2021-09-10 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 16:14 Jonas Bernoulli [this message]
2021-09-11 13:05 ` bug#50511: 27.2; url-http-handle-authentication should not raise error Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y284l85d.fsf@bernoul.li \
--to=jonas@bernoul.li \
--cc=50511@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).