From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50571: 28.0.50; Redisplay segfaults with empty face cache Date: Tue, 14 Sep 2021 20:45:18 +0100 Message-ID: <87y27zuek1.fsf@tcd.ie> References: <87ilz4msha.fsf@tcd.ie> <831r5sea46.fsf@gnu.org> <87a6kggiz6.fsf@tcd.ie> <83bl4vcnsp.fsf@gnu.org> <83a6kfcmdk.fsf@gnu.org> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29778"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50571@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 14 21:46:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQENe-0007TU-TD for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 21:46:10 +0200 Original-Received: from localhost ([::1]:36172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQENc-0004vP-VX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 15:46:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQENX-0004v7-3M for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 15:46:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38683) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQENV-0003Ln-Vw for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 15:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQENV-0000jf-SN for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 15:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Sep 2021 19:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50571 X-GNU-PR-Package: emacs Original-Received: via spool by 50571-submit@debbugs.gnu.org id=B50571.16316487292789 (code B ref 50571); Tue, 14 Sep 2021 19:46:01 +0000 Original-Received: (at 50571) by debbugs.gnu.org; 14 Sep 2021 19:45:29 +0000 Original-Received: from localhost ([127.0.0.1]:50229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQEMy-0000iv-Tp for submit@debbugs.gnu.org; Tue, 14 Sep 2021 15:45:29 -0400 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:36658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQEMw-0000ih-JT for 50571@debbugs.gnu.org; Tue, 14 Sep 2021 15:45:28 -0400 Original-Received: by mail-wr1-f44.google.com with SMTP id g16so101715wrb.3 for <50571@debbugs.gnu.org>; Tue, 14 Sep 2021 12:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lRLBGJUC8FN5tK3onyWVBwIwnBUQUeXVjJC35rxvnJs=; b=KfZ06Y9vwy8beqzaIo+tGATn26g6qGLProIxThfY/sZitX/kSdbgLb2ZDsnoCxMMEL yfDMPXJfcvO2o3p+IPvs/dqNQCUmXoaG9Icd8Egu0+twyNjj0bZUid8zZkCvAFjrRyiT s9GyLX70sr07idhu2J3Z2Dv6DgfqLRz4hdrk1j5dk2OKqO3XR/2P7B9w0hwH3ODpEite OKrmQOYZUPuvKQswvl/+W2M+Oy5qQ3xcjNv2BMl/mCzqoyG3/1sFhWuN+qe3niDEWOFl 1+VHysnE95gutFx1k4nzNVrrxXQB7Z8XTEpLrSR6V5E6BJi8MBUrYuuDiQWmKM2gx4T/ JEMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lRLBGJUC8FN5tK3onyWVBwIwnBUQUeXVjJC35rxvnJs=; b=FZ1r7GzJGqgJSz2q48J1NpVMe12PGw4GHUsIAJcOp9NV6rceuQipU3F5dOeG7gAyWL tRVNuGicmwsMnuta1ZPuOTUR8o8oZrptKS37WbVLTpvFA40jTtXPmcTmx0slMs6hYddK dMeVRXRcBO9GjvuT9L22Dc9p8oa7sDMbapcT6MxtexPl2viLSjbbvTjHkD7TN7phYthc fsg09aSxCfx+6tqkn+/wumeWpVw5H6KShJjiHUKXXI8CqQjIBJBo65DQAuNY30ueGMVe svQVI3Dw6feKYCSSIxgKhkbN0a95TFpzDYJ0C1TZcEnIOLn4Rafka07AyWmS2hz9GAGp zRLQ== X-Gm-Message-State: AOAM531A+KcY0oTlP7iqkygjjMmb/Ye9Yk1OFD7/TPU4HjIdRfkrRPnb ISNAUyVLYbAjOKzuUESqDeMSrQ== X-Google-Smtp-Source: ABdhPJy1KaaFuk23oVJrHY1jMVOZepMitphH2w6lzRzOcDz12hjQBMAoG8qqSTnKxBlhdx8LR9KKXw== X-Received: by 2002:adf:eb02:: with SMTP id s2mr933040wrn.294.1631648720627; Tue, 14 Sep 2021 12:45:20 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id u25sm2044854wmj.10.2021.09.14.12.45.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 12:45:19 -0700 (PDT) In-Reply-To: <83a6kfcmdk.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Sep 2021 16:33:43 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214338 Archived-At: Eli Zaretskii [2021-09-14 16:33 +0300] wrote: >> Date: Tue, 14 Sep 2021 16:03:02 +0300 >> From: Eli Zaretskii >> Cc: 50571@debbugs.gnu.org >> >> Thanks, I see the reason now. It's because we allow to have arbitrary >> Lisp to be registered in jit-lock-functions, and then that arbitrary >> Lisp is called in the middle of redisplay, and in this case creates a >> whole new frame with faces. As luck would have it, we decide right >> there and then perform routine maintenance and release all the faces >> on all the frames... >> >> I'm thinking about the best solution for this. > > Does the patch below give good results? Yes, applying it makes the issue go away, and reverting it reintroduces the segfault. I didn't notice any other issues. Thanks! -- Basil