From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 50571@debbugs.gnu.org
Subject: bug#50571: 28.0.50; Redisplay segfaults with empty face cache
Date: Tue, 14 Sep 2021 20:45:18 +0100 [thread overview]
Message-ID: <87y27zuek1.fsf@tcd.ie> (raw)
In-Reply-To: <83a6kfcmdk.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Sep 2021 16:33:43 +0300")
Eli Zaretskii [2021-09-14 16:33 +0300] wrote:
>> Date: Tue, 14 Sep 2021 16:03:02 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: 50571@debbugs.gnu.org
>>
>> Thanks, I see the reason now. It's because we allow to have arbitrary
>> Lisp to be registered in jit-lock-functions, and then that arbitrary
>> Lisp is called in the middle of redisplay, and in this case creates a
>> whole new frame with faces. As luck would have it, we decide right
>> there and then perform routine maintenance and release all the faces
>> on all the frames...
>>
>> I'm thinking about the best solution for this.
>
> Does the patch below give good results?
Yes, applying it makes the issue go away, and reverting it reintroduces
the segfault. I didn't notice any other issues. Thanks!
--
Basil
next prev parent reply other threads:[~2021-09-14 19:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 14:59 bug#50571: 28.0.50; Redisplay segfaults with empty face cache Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-13 16:03 ` Eli Zaretskii
2021-09-13 23:21 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 13:03 ` Eli Zaretskii
2021-09-14 13:33 ` Eli Zaretskii
2021-09-14 19:45 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-09-15 13:16 ` Eli Zaretskii
2021-09-19 13:57 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-19 15:47 ` Eli Zaretskii
2021-09-19 18:21 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-19 18:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y27zuek1.fsf@tcd.ie \
--to=bug-gnu-emacs@gnu.org \
--cc=50571@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).