From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Federico Tedin Newsgroups: gmane.emacs.bugs Subject: bug#49723: 28.0.50; Test in coding.c for NUL bytes in filenames is not reliable Date: Thu, 16 Sep 2021 20:38:03 +0200 Message-ID: <87y27wxt6c.fsf@gmail.com> References: <83o8ary5kl.fsf@gnu.org> <87pmtbj81v.fsf@gmail.com> <8335q7c655.fsf@gnu.org> <87pmta6buq.fsf@gmail.com> <837dfgaerv.fsf@gnu.org> <8735q4zcdh.fsf@gmail.com> <87tuikl79i.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37350"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: phst@google.com, 49723@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 16 20:39:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQwHw-0009ZJ-HD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Sep 2021 20:39:12 +0200 Original-Received: from localhost ([::1]:40690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQwHu-0000gZ-QZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Sep 2021 14:39:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQwHm-0000gP-Uw for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 14:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45004) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQwHm-00027F-Gj for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 14:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQwHm-0002ub-Es for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 14:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Federico Tedin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Sep 2021 18:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49723 X-GNU-PR-Package: emacs Original-Received: via spool by 49723-submit@debbugs.gnu.org id=B49723.163181750911140 (code B ref 49723); Thu, 16 Sep 2021 18:39:02 +0000 Original-Received: (at 49723) by debbugs.gnu.org; 16 Sep 2021 18:38:29 +0000 Original-Received: from localhost ([127.0.0.1]:56550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQwHD-0002tZ-2y for submit@debbugs.gnu.org; Thu, 16 Sep 2021 14:38:28 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:51079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQwGx-0002sy-6p for 49723@debbugs.gnu.org; Thu, 16 Sep 2021 14:38:25 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id 140so5526934wma.0 for <49723@debbugs.gnu.org>; Thu, 16 Sep 2021 11:38:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UMLY/VMqU8JyRGwC8cyu58yxr0pRQnVrl0bqVWkVoIk=; b=nOTu0N29IJMVsMPJBWOBD5dRQ+4/gxGwJrQFb2oJfD5YpyEU1ts1IyNYWcPjOOHSDV OuB2Gt3gMWJJmZb9OLGHxk8IueapROFEOTA+W2yZgChHoZ8dKCtolJY/TNYPdwuzt4oQ 0Ocjq9nDT2SwBVN9S2x2XuK3DWKQWtS0EX5x0nDvNWJ8Uj5wWdFVvvzCOSmLJ7CYel9u Lho4Q608Cqh9+bC6EH4WTOjs0kle9hiGI5p83dQRej9ErSK4UmNCduIBulhoBxzcMbrH upzvjFXsYRki1wR8UQ8AxSKkxtRT3R/xkK14Y9x4Qo4csSNiaXmi3fR4SkYFPgFFYp4F aYYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=UMLY/VMqU8JyRGwC8cyu58yxr0pRQnVrl0bqVWkVoIk=; b=2LT7oJFjYy0plQmyGea2nAci4UqibSxGAK3FI4FTmJhoTW04A+y5EdVGqHoUZgUxz5 7grYsbK7lnbcbBtH4u3Qg4qauYPaEOAD9COFP+pnRfjOgqxIgqmZeSHHX2U0bKSNHuoe vQzzHNkMcgczXve90VkIUOYfhKO7MVYrLXaSrcmplAI3dfDdnSZA7qKZ+JRQKuQJM3KU CE6TXM1l91ta4VELloZKnPUv4h9Do4sVErLz6yvptkuSyVwCQAD4ZYU8GcNyjHHwQ5pb fwQJMWiR/cCJcmdsjsoz3pUBv7jlOa29v+52jwM0SstfOsse93tVugHUgkeI66d+8YF8 na6w== X-Gm-Message-State: AOAM530v4JG4UG10J8potjZ80ov6Wow+Bk30XGuLovMPGbD+dLRGDMt3 0LRN9XtSxppiMAxCmjFR45dTHFYgXRhR7g== X-Google-Smtp-Source: ABdhPJzQ3vEmblBcHSwabc3/4xgqzH+HZeictIJFgMpu2IEod6WNGNXJ0/bFw/FxJS7mq54bffpANw== X-Received: by 2002:a05:600c:22d6:: with SMTP id 22mr6518977wmg.17.1631817484963; Thu, 16 Sep 2021 11:38:04 -0700 (PDT) Original-Received: from gehirn (ip5b4202e5.dynamic.kabel-deutschland.de. [91.66.2.229]) by smtp.gmail.com with ESMTPSA id s13sm8432882wmc.47.2021.09.16.11.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 11:38:04 -0700 (PDT) In-Reply-To: <87tuikl79i.fsf@gmx.de> (Michael Albinus's message of "Thu, 16 Sep 2021 20:12:09 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214498 Archived-At: Michael Albinus writes: > Federico Tedin writes: > > Hi, > > Sorry for being late, I have seen this just now only. > >> +** 'expand-file-name' now checks for null bytes in filenames. >> +The function will now check for null bytes in both NAME and >> +DEFAULT-DIRECTORY arguments, as well as in the 'default-directory' >> +buffer-local variable, assuming its value is used. If null bytes are >> +found, 'expand-file-name' will signal an error. > > Should this be implemented also in remote file names? > > Best regards, Michael. Would this imply only doing it in `tramp-handle-expand-file-name`, or other functions as well? I had thought of doing it for at least `tramp-handle-expand-file-name`, but then I noticed that the function eventually calls `expand-file-name` with a combination of name + dir, or only with name. So in that case I figured that the null bytes check would be performed by `expand-file-name` anyways.